Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Introduce builder pattern for LocationComponent activation #13931

Closed
LukasPaczos opened this issue Feb 14, 2019 · 1 comment · Fixed by #13941
Closed

Introduce builder pattern for LocationComponent activation #13931

LukasPaczos opened this issue Feb 14, 2019 · 1 comment · Fixed by #13941
Assignees
Labels
Android Mapbox Maps SDK for Android refactor

Comments

@LukasPaczos
Copy link
Member

LukasPaczos commented Feb 14, 2019

With a growing number of LocationComponent#activate parameters and all of them requiring permutations and creating overrides, it's starting to get hard to maintain. It'd be great to expose a LocationComponent#ActivationBuilder that would be passed into a single LocationComponent#activate method.

We can expose such a builder and deprecate all of the #activation overrides without breaking the semver.

@carstenhag
Copy link

As commented on #13941 (comment), somehow the depreciation notices don't show what else to use because the comments gets removed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android refactor
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants