Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

[android] Adding new variation of LocationComponent#activateLocationComponent #13909

Conversation

langsmith
Copy link
Contributor

As I looked into customizing the LocationComponent, I discovered that the LocationComponent could use a new version of the activateLocationComponent() method. There wasn't an activation method which took a certain mix of 4 parameters. This pr enables the ability to pass in Context, Style, useDefaultLocationEngine, and LocationComponentOptions .

screen shot 2019-02-11 at 2 57 32 pm

screen shot 2019-02-11 at 3 06 20 pm

screen shot 2019-02-11 at 2 57 37 pm

Related: #13829

@langsmith langsmith added the Android Mapbox Maps SDK for Android label Feb 11, 2019
@langsmith langsmith self-assigned this Feb 11, 2019
@LukasPaczos
Copy link
Member

Do you think we could skip this one and capture it in the #13931 instead?

@langsmith
Copy link
Contributor Author

Would love for this to land in master so that I can use this in a project or two, haha 👀

Happy to wait if you really think the builder should come before adding this new version of activateComponent().

@LukasPaczos
Copy link
Member

Since you can always pass LocationComponentOptions right after activation, I'd love to limit the number of overrides and go straight for the builder :)

Would you be able to find bandwidth to run point on that and try to get this into 7.2.0? It'd have to land before the branch cut on Tuesday.

@langsmith
Copy link
Contributor Author

Closing this in favor of #13941

@langsmith langsmith closed this Mar 1, 2019
@langsmith langsmith deleted the ls-adding-another-android-activateLocationComponent-constructor-variation branch March 1, 2019 22:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants