Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Rotation causes some labels to collide #1689

Closed
1ec5 opened this issue Jun 4, 2015 · 3 comments
Closed

Rotation causes some labels to collide #1689

1ec5 opened this issue Jun 4, 2015 · 3 comments
Assignees
Labels

Comments

@1ec5
Copy link
Contributor

1ec5 commented Jun 4, 2015

I’m seeing a couple labels collide:

collision

As soon as I change styles, that overlapping “N 4th St” label disappears, and it stays hidden if I change back to the original style (Mapbox Streets):

uncollision

But if I gingerly rotate the map, the “N 4th St” label reappears, and resetting the rotation doesn’t fix the collision.

This is with the changes for #1666. Doesn’t reproduce in mapbox-gl-js.

@mikemorris
Copy link
Contributor

Reopening this with some new examples of collisions I've noticed from MapMode::Still renders with a rotation applied. I suspect these are old bugs we just never caught, not recent regressions.

Collision between Valley Stream, Hempstead and a route marker
image

Collision between Point Reyes National Seashore and a route marker, San Francisco and Oakland labels appear to collide as well
image

/cc @ansis

@mikemorris mikemorris reopened this Mar 24, 2016
@mikemorris mikemorris removed the iOS Mapbox Maps SDK for iOS label Mar 24, 2016
@ansis
Copy link
Contributor

ansis commented Mar 30, 2016

@mikemorris what is the code / setup for reproducing these? can you render the images with collision boxes?

@ansis
Copy link
Contributor

ansis commented Apr 4, 2016

@mikemorris thinks #1689 (comment) is a bug in the project that uses mapbox-gl-native.

@ansis ansis closed this as completed Apr 4, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants