All animations broken

[friedbunny]

Tapping the compass no longer reliably resets the bearing — upon tapping, the compass will sometimes stutter towards north a few degrees and halt. Other times the compass will haltingly reset to north and disappear.

Not seeing any particular pattern right now.

/cc @mapbox/mobile

[ljbade]

Happens on Android too, noticed in #1856 (comment)

[1ec5]

#1829 changed the iOS compass to rely on mbgl for frame updates, whereas it used to use view-based animation. So this is definitely a bug in mbgl’s update notifications.

[1ec5]

This is causing -[MapViewTests testCompassTap] to fail reliably.

[1ec5]

Regression from fa4636f for #1979.

[incanus]

iOS tests should have caught this, yes? Why didn't they?

https://travis-ci.org/mapbox/mapbox-gl-native/builds/74223611

[1ec5]

The tests have been catching the issue about 80% of the time. I had thought it was #1887, but those failures were just burying this one.

[1ec5]

Probably related: when tracking user location, the user dot often shuffles out of view.

[1ec5]

All animation is broken, and I’m having a difficult time untangling fa4636f. @brunoabinader, can you look into this?

[1ec5]

I may have confused the bisect by starting with release-0.5.0 as good, but when I start with two revisions on master, I get this commit instead: 0a527f6. #2026 is interesting because perhaps this constant redrawing was only masking the underlying problem. Maybe that underlying problem was introduced in fa4636f.

/cc @kkaefer

[brunoabinader]

I am AFK this Thursday and Friday, will have a look on my way to US this weekend.
/cc @tmpsantos

[brunoabinader]

Got lucky with wifi onboard, so I managed to find the root cause: mbgl::Transform::{_moveBy,_setAngle} were returning Update::Nothing, causing the render call to not repaint. Changing those to Update::Repaint fixed all the aforementioned issues. Fixed in #2060.

[brunoabinader]

Reopening issue for proper validation. I've tested on an iPad, iPhone 6 (via simulator), Android, GLFW and Qt-based ports in OSX, clicking on compass button now properly resets bearing to North, and all other animations are working as should. Please verify?

[ljbade]

Works on Android

[1ec5]

Works great on iOS 8.4 on an iPhone 6 and on the iOS 9 Simulator.

[friedbunny]

Looks good on-device — iPhone 5, iOS 9. 👍