Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

All animations broken #2036

Closed
friedbunny opened this issue Aug 11, 2015 · 15 comments
Closed

All animations broken #2036

friedbunny opened this issue Aug 11, 2015 · 15 comments
Assignees
Labels
Android Mapbox Maps SDK for Android bug iOS Mapbox Maps SDK for iOS
Milestone

Comments

@friedbunny
Copy link
Contributor

Tapping the compass no longer reliably resets the bearing — upon tapping, the compass will sometimes stutter towards north a few degrees and halt. Other times the compass will haltingly reset to north and disappear.

Not seeing any particular pattern right now.

/cc @mapbox/mobile

@friedbunny friedbunny added bug iOS Mapbox Maps SDK for iOS labels Aug 11, 2015
@ljbade ljbade added the Android Mapbox Maps SDK for Android label Aug 11, 2015
@ljbade
Copy link
Contributor

ljbade commented Aug 11, 2015

Happens on Android too, noticed in #1856 (comment)

@1ec5
Copy link
Contributor

1ec5 commented Aug 11, 2015

#1829 changed the iOS compass to rely on mbgl for frame updates, whereas it used to use view-based animation. So this is definitely a bug in mbgl’s update notifications.

@1ec5
Copy link
Contributor

1ec5 commented Aug 11, 2015

This is causing -[MapViewTests testCompassTap] to fail reliably.

@1ec5 1ec5 self-assigned this Aug 11, 2015
@1ec5 1ec5 added this to the v0.6.0 milestone Aug 11, 2015
@1ec5
Copy link
Contributor

1ec5 commented Aug 11, 2015

Regression from fa4636f for #1979.

@incanus
Copy link
Contributor

incanus commented Aug 11, 2015

iOS tests should have caught this, yes? Why didn't they?

https://travis-ci.org/mapbox/mapbox-gl-native/builds/74223611

@1ec5
Copy link
Contributor

1ec5 commented Aug 12, 2015

The tests have been catching the issue about 80% of the time. I had thought it was #1887, but those failures were just burying this one.

@1ec5
Copy link
Contributor

1ec5 commented Aug 12, 2015

Probably related: when tracking user location, the user dot often shuffles out of view.

@1ec5 1ec5 assigned brunoabinader and unassigned 1ec5 Aug 12, 2015
@1ec5
Copy link
Contributor

1ec5 commented Aug 12, 2015

All animation is broken, and I’m having a difficult time untangling fa4636f. @brunoabinader, can you look into this?

@1ec5 1ec5 changed the title Compass fails to reset on tap All animations broken Aug 12, 2015
@1ec5
Copy link
Contributor

1ec5 commented Aug 12, 2015

I may have confused the bisect by starting with release-0.5.0 as good, but when I start with two revisions on master, I get this commit instead: 0a527f6. #2026 is interesting because perhaps this constant redrawing was only masking the underlying problem. Maybe that underlying problem was introduced in fa4636f.

/cc @kkaefer

@brunoabinader
Copy link
Member

I am AFK this Thursday and Friday, will have a look on my way to US this weekend.
/cc @tmpsantos

brunoabinader added a commit that referenced this issue Aug 13, 2015
Transform::{_moveBy,_setAngle} were returning Update::Nothing, causing
the render to not repaint. Replacing with Update::Repaint fixes the
issue.

Fixes #2036.
@brunoabinader
Copy link
Member

Got lucky with wifi onboard, so I managed to find the root cause: mbgl::Transform::{_moveBy,_setAngle} were returning Update::Nothing, causing the render call to not repaint. Changing those to Update::Repaint fixed all the aforementioned issues. Fixed in #2060.

@brunoabinader
Copy link
Member

Reopening issue for proper validation. I've tested on an iPad, iPhone 6 (via simulator), Android, GLFW and Qt-based ports in OSX, clicking on compass button now properly resets bearing to North, and all other animations are working as should. Please verify?

@ljbade
Copy link
Contributor

ljbade commented Aug 13, 2015

Works on Android

@1ec5
Copy link
Contributor

1ec5 commented Aug 13, 2015

Works great on iOS 8.4 on an iPhone 6 and on the iOS 9 Simulator.

@1ec5 1ec5 closed this as completed Aug 13, 2015
@friedbunny
Copy link
Contributor Author

Looks good on-device — iPhone 5, iOS 9. 👍

AndwareSsj pushed a commit to AndwareSsj/mapbox-gl-native that referenced this issue Nov 6, 2015
Transform::{_moveBy,_setAngle} were returning Update::Nothing, causing
the render to not repaint. Replacing with Update::Repaint fixes the
issue.

Fixes mapbox#2036.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android bug iOS Mapbox Maps SDK for iOS
Projects
None yet
Development

No branches or pull requests

6 participants