Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Use TextureView #2244

Closed
ljbade opened this issue Sep 3, 2015 · 12 comments
Closed

Use TextureView #2244

ljbade opened this issue Sep 3, 2015 · 12 comments
Assignees
Labels
Android Mapbox Maps SDK for Android refactor

Comments

@ljbade
Copy link
Contributor

ljbade commented Sep 3, 2015

Now that we target API level 15 and above we should switch to TextureView

The advantage is that we can treat a MapView the same as any other View. This will allow advanced layouts and may avoid bugs such as #2018 and #1894

@bleege Do we want to do this in 0.1.0 or 0.2.0?

@ljbade ljbade added the Android Mapbox Maps SDK for Android label Sep 3, 2015
@ljbade ljbade self-assigned this Sep 3, 2015
ljbade pushed a commit that referenced this issue Sep 3, 2015
@ljbade
Copy link
Contributor Author

ljbade commented Sep 3, 2015

Started work on this.

@tobrun
Copy link
Member

tobrun commented Sep 3, 2015

Nice, looking forward seeing this working!

Hopefully this will not be an issue:

The main strike against TextureView is the performance of the composition step. With SurfaceView, the content is written to a separate layer that SurfaceFlinger composites, ideally with an overlay. With TextureView, the View composition is always performed with GLES, and updates to its contents may cause other View elements to redraw as well (e.g. if they're positioned on top of the TextureView)

@bleege
Copy link
Contributor

bleege commented Sep 3, 2015

Do we want to do this in 0.1.0 or 0.2.0?

0.2.0. @ljbade This sounds like a good thing, but it's too late for 0.1.0.

@bleege bleege modified the milestones: android-v0.1.0, android-v0.2.0 Sep 3, 2015
@ljbade
Copy link
Contributor Author

ljbade commented Sep 3, 2015

@bleege Sure we might have to move those bugs to 0.2.0 then.

@bleege
Copy link
Contributor

bleege commented Sep 8, 2015

Moving this to 0.1.0 as it solves Translucent Status bar issue in #1894 . See #1894 (comment) for more details.

Is there anything more to be done @ljbade or can we merge this one in as is?

@mb12
Copy link

mb12 commented Sep 8, 2015

@ tobrun Were you able to reproduce the original issue without these changes? My understanding is that this is a speculative fix for an issue which is not reproducible with latest master.

@tobrun
Copy link
Member

tobrun commented Sep 8, 2015

@mb12 will do a small test before it gets merged

@incanus
Copy link
Contributor

incanus commented Sep 8, 2015

Per chat with @bleege, we are going to move this back to 0.2.0 since it's a bit of a refactor and is triggered only in an edge case. We can quickly wrap it into the next release cycle and go from there.

@incanus incanus modified the milestones: android-v0.2.0, android-v0.1.0 Sep 8, 2015
@ljbade ljbade modified the milestones: android-v0.1.0, android-v0.2.0 Sep 8, 2015
@tobrun
Copy link
Member

tobrun commented Sep 9, 2015

@mb12
Problem still exists on master so TextureView is a valid fix.

Nice job @ljbade 👍

device-2015-09-09-150700

@mb12
Copy link

mb12 commented Sep 9, 2015

Great fix. This was a tough one.

@bleege
Copy link
Contributor

bleege commented Sep 9, 2015

Thanks for the feedback and tire kicking @tobrun @mb12 and @ljbade for making this happen. @incanus and I just discussed this and decided that we will make the time to include this now. Hopefully this will also solve #1894 too.

@bleege bleege modified the milestones: android-v0.1.0, android-v0.2.0 Sep 9, 2015
@ljbade ljbade closed this as completed in 73c3af4 Sep 9, 2015
@ljbade ljbade removed the in progress label Sep 9, 2015
@bleege
Copy link
Contributor

bleege commented Sep 9, 2015

Merged.

ljbade pushed a commit that referenced this issue Sep 11, 2015
AndwareSsj pushed a commit to AndwareSsj/mapbox-gl-native that referenced this issue Nov 6, 2015
AndwareSsj pushed a commit to AndwareSsj/mapbox-gl-native that referenced this issue Nov 6, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android refactor
Projects
None yet
Development

No branches or pull requests

5 participants