-
Notifications
You must be signed in to change notification settings - Fork 1.3k
"LatLngZoom" & "Coordinate": do they mean the same thing? #3309
Comments
Center CoordinateI'm not really sure where the naming of Google MapsI'm seeing that Google Maps SDK is using a Camera object for this.
Side noteI want to add to this discussion we are sometimes calling a LatLng instance mMapView.setOnMapLongClickListener(new MapView.OnMapLongClickListener() {
@Override
public void onMapLongClick(@NonNull LatLng point) {
// awesome code here
}
}); This is something that needs to be changed as well. @tmcw thank you for this valuable feedback, always good to have some extra 👀 |
I did some sleuthing and found that it comes from 5-Nov-2014.... aka "the first Android PR". It's odd as usually there's been a one to one mapping between Regardless, let's move away from this now. With the Mapbox Camera API now in, we can mirror Google's approach by using |
This will be resolved if #3145 lands |
@tobrun Since #3145 is a bit of a bigger lift that may or may not be ready by the time we're ready to release the next PROD version of the SDK let's knock this issue out first as getting things named consistently is important. Cool? |
Agreed, will pick this up now |
Our external-facing API has
Map.setCenterCoordinate(LatLngZoom)
that dispatches toMap.setLatLng
andMap.setLatLngZoom
. We don't have a class called 'Coordinate' anywhere.Should LatLng be derived from a Coordinate class? Should it be renamed Coordinate? The two names seem to correspond to the same thing.
The text was updated successfully, but these errors were encountered: