-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Move Custom Layer in test app #3348
Comments
cc @jfirebaugh |
Yep, moving the Custom Layer option to
Could you explain this reasoning a bit more? |
I was indeed referring to |
Feel free to reorganize however you want. |
…ed Custom Layer to Main Activity Controls in Nav Drawer with new icon.
I've moved the
12-21 09:55:36.298 7543-7543/com.mapbox.mapboxsdk.testapp A/art: art/runtime/java_vm_ext.cc:410] JNI DETECTED ERROR IN APPLICATION: JNI RegisterNatives called with pending exception java.lang.ClassNotFoundException: Didn't find class "com.mapbox.mapboxsdk.testapp.ExampleCustomLayer" on path: DexPathList[[zip file "/data/app/com.mapbox.mapboxsdk.testapp-1/base.apk"],nativeLibraryDirectories=[/data/app/com.mapbox.mapboxsdk.testapp-1/lib/arm, /data/app/com.mapbox.mapboxsdk.testapp-1/base.apk!/lib/armeabi-v7a, /vendor/lib, /system/lib]]
12-21 09:55:36.298 7543-7543/com.mapbox.mapboxsdk.testapp A/art: art/runtime/java_vm_ext.cc:410] at java.lang.Class dalvik.system.BaseDexClassLoader.findClass(java.lang.String) (BaseDexClassLoader.java:56)
12-21 09:55:36.298 7543-7543/com.mapbox.mapboxsdk.testapp A/art: art/runtime/java_vm_ext.cc:410] at java.lang.Class java.lang.ClassLoader.loadClass(java.lang.String, boolean) (ClassLoader.java:511)
12-21 09:55:36.298 7543-7543/com.mapbox.mapboxsdk.testapp A/art: art/runtime/java_vm_ext.cc:410] at java.lang.Class java.lang.ClassLoader.loadClass(java.lang.String) (ClassLoader.java:469)
12-21 09:55:36.298 7543-7543/com.mapbox.mapboxsdk.testapp A/art: art/runtime/java_vm_ext.cc:410] at java.lang.String java.lang.Runtime.nativeLoad(java.lang.String, java.lang.ClassLoader, java.lang.String) (Runtime.java:-2)
12-21 09:55:36.298 7543-7543/com.mapbox.mapboxsdk.testapp A/art: art/runtime/java_vm_ext.cc:410] at java.lang.String java.lang.Runtime.doLoad(java.lang.String, java.lang.ClassLoader) (Runtime.java:435)
12-21 09:55:36.298 7543-7543/com.mapbox.mapboxsdk.testapp A/art: art/runtime/java_vm_ext.cc:410] at void java.lang.Runtime.loadLibrary(java.lang.String, java.lang.ClassLoader) (Runtime.java:370)
12-21 09:55:36.298 7543-7543/com.mapbox.mapboxsdk.testapp A/art: art/runtime/java_vm_ext.cc:410] at void java.lang.System.loadLibrary(java.lang.String) (System.java:1076)
12-21 09:55:36.298 7543-7543/com.mapbox.mapboxsdk.testapp A/art: art/runtime/java_vm_ext.cc:410] at void com.mapbox.mapboxsdk.testapp.layers.ExampleCustomLayer.<clinit>() (ExampleCustomLayer.java:5)
12-21 09:55:36.298 7543-7543/com.mapbox.mapboxsdk.testapp A/art: art/runtime/java_vm_ext.cc:410] at void com.mapbox.mapboxsdk.testapp.MainActivity.addCustomLayer() (MainActivity.java:590)
12-21 09:55:36.298 7543-7543/com.mapbox.mapboxsdk.testapp A/art: art/runtime/java_vm_ext.cc:410] at void com.mapbox.mapboxsdk.testapp.MainActivity.access$1200(com.mapbox.mapboxsdk.testapp.MainActivity) (MainActivity.java:49)
12-21 09:55:36.298 7543-7543/com.mapbox.mapboxsdk.testapp A/art: art/runtime/java_vm_ext.cc:410] at boolean com.mapbox.mapboxsdk.testapp.MainActivity$7.onNavigationItemSelected(android.view.MenuItem) (MainActivity.java:409)
12-21 09:55:36.298 7543-7543/com.mapbox.mapboxsdk.testapp A/art: art/runtime/java_vm_ext.cc:410] at boolean android.support.design.widget.NavigationView$1.onMenuItemSelected(android.support.v7.view.menu.MenuBuilder, android.view.MenuItem) (NavigationView.java:150)
12-21 09:55:36.298 7543-7543/com.mapbox.mapboxsdk.testapp A/art: art/runtime/java_vm_ext.cc:410] at boolean android.support.v7.view.menu.MenuBuilder.dispatchMenuItemSelected(android.support.v7.view.menu.MenuBuilder, android.view.MenuItem) (MenuBuilder.java:811)
12-21 09:55:36.298 7543-7543/com.mapbox.mapboxsdk.testapp A/art: art/runtime/java_vm_ext.cc:410] at boolean android.support.v7.view.menu.SubMenuBuilder.dispatchMenuItemSelected(android.support.v7.view.menu.MenuBuilder, android.view.MenuItem) (SubMenuBuilder.java:84)
12-21 09:55:36.298 7543-7543/com.mapbox.mapboxsdk.testapp A/art: art/runtime/java_vm_ext.cc:410] at boolean android.support.v7.view.menu.MenuItemImpl.invoke() (MenuItemImpl.java:152)
12-21 09:55:36.298 7543-7543/com.mapbox.mapboxsdk.testapp A/art: art/runtime/java_vm_ext.cc:410] at boolean android.support.v7.view.menu.MenuBuilder.performItemAction(android.view.MenuItem, android.support.v7.view.menu.MenuPresenter, int) (MenuBuilder.java:958)
12-21 09:55:36.298 7543-7543/com.mapbox.mapboxsdk.testapp A/art: art/runtime/java_vm_ext.cc:410] at void android.support.design.internal.NavigationMenuPresenter$1.onClick(android.view.View) (NavigationMenuPresenter.java:308)
12-21 09:55:36.298 7543-7543/com.mapbox.mapboxsdk.testapp A/art: art/runtime/java_vm_ext.cc:410] at boolean android.view.View.performClick() (View.java:5204)
12-21 09:55:36.298 7543-7543/com.mapbox.mapboxsdk.testapp A/art: art/runtime/java_vm_ext.cc:410] at void android.view.View$PerformClick.run() (View.java:21153)
12-21 09:55:36.298 7543-7543/com.mapbox.mapboxsdk.testapp A/art: art/runtime/java_vm_ext.cc:410] at void android.os.Handler.handleCallback(android.os.Message) (Handler.java:739)
12-21 09:55:36.298 7543-7543/com.mapbox.mapboxsdk.testapp A/art: art/runtime/java_vm_ext.cc:410] at void android.os.Handler.dispatchMessage(android.os.Message) (Handler.java:95)
12-21 09:55:36.298 7543-7543/com.mapbox.mapboxsdk.testapp A/art: art/runtime/java_vm_ext.cc:410] at void android.os.Looper.loop() (Looper.java:148)
12-21 09:55:36.298 7543-7543/com.mapbox.mapboxsdk.testapp A/art: art/runtime/java_vm_ext.cc:410] at void android.app.ActivityThread.main(java.lang.String[]) (ActivityThread.java:5417)
12-21 09:55:36.299 7543-7543/com.mapbox.mapboxsdk.testapp A/art: art/runtime/java_vm_ext.cc:410] at java.lang.Object java.lang.reflect.Method.invoke!(java.lang.Object, java.lang.Object[]) (Method.java:-2)
12-21 09:55:36.299 7543-7543/com.mapbox.mapboxsdk.testapp A/art: art/runtime/java_vm_ext.cc:410] at void com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run() (ZygoteInit.java:726)
12-21 09:55:36.299 7543-7543/com.mapbox.mapboxsdk.testapp A/art: art/runtime/java_vm_ext.cc:410] at void com.android.internal.os.ZygoteInit.main(java.lang.String[]) (ZygoteInit.java:616) |
You'll have to change this line. |
That did the trick! I updated the line and ran Thanks @jfirebaugh! |
Merged! |
Visually in the test app
Currently the custom layer option is shown in the list of feature activities, I believe that this should be moved to the
Main Activity Controls
instead because it is manipulating theMapView
from theMainActivity
. Also we need to have a different icon for this we are reusing thePolyline
one.Introduce package
All classes in the default package are
Activities
,I believe we should move
CustomLayer
to a separate package to avoid confusion.cc @bleege @zugaldia
The text was updated successfully, but these errors were encountered: