Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

[core] Text placement might block the Map Thread #3727

Closed
tmpsantos opened this issue Jan 28, 2016 · 0 comments · Fixed by #3731
Closed

[core] Text placement might block the Map Thread #3727

tmpsantos opened this issue Jan 28, 2016 · 0 comments · Fixed by #3731
Assignees
@ansis
Labels
performance Speed, stability, CPU usage, memory usage, or power usage

Comments

@tmpsantos
Copy link
Contributor

When redoing the text placement we try to cancel any ongoing task on the worker and that might block (see #2644) and cause the UI to hang.

We should never block and at the same time we must make sure that the text placement is deterministic, which is the reason why the current code tries to stop the ongoing redo placement task and start a new one synchronously.

/cc @ansis
@tmpsantos tmpsantos added the performance Speed, stability, CPU usage, memory usage, or power usage label Jan 28, 2016
@ansis ansis mentioned this issue Jan 28, 2016
Merged
ansis added a commit that referenced this issue Jan 29, 2016
@ansis
[core] fix redoPlacement blocking main thread, fix #3727
0439d00 
If a workRequest exists, don't cancel it and start an new request. It's
ok to just do nothing if the request exists because a new call to
redoPlacement will be triggered after the existing request finishes.

this fixes a regression in e44db93
@ansis ansis removed the in progress label Jan 29, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ansis ansis

Labels
performance Speed, stability, CPU usage, memory usage, or power usage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix redoPlacement blocking main thread, fix #3727 mapbox/mapbox-gl-native
2 participants
@tmpsantos @ansis