Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Support an OfflineRegionDefinition defined by an arbitrary shape #4106

Closed
zugaldia opened this issue Feb 24, 2016 · 5 comments
Closed

Support an OfflineRegionDefinition defined by an arbitrary shape #4106

zugaldia opened this issue Feb 24, 2016 · 5 comments
Labels
Core The cross-platform C++ core, aka mbgl feature offline

Comments

@zugaldia
Copy link
Member

At this moment we only support an OfflineTilePyramidRegionDefinition defined by a bounding box. We should let developers use arbitrary shapes to match, for example, the shape of a state, province, etc.

/cc: @jfirebaugh @1ec5

@jfirebaugh
Copy link
Contributor

The pieces that we would need to support this are:

  • A set of C++ types representing geographic features. Probably strongly GeoJSON influenced so we could reuse these types for featuresAt results and geoJSONLayer.setData(). Could potentially be extracted from geojsonvt-cpp. (cc @springmeyer)
  • For each platform, bindings to the above.
  • An implementation of tileCover for the above.

@twbell
Copy link

twbell commented Apr 20, 2016

Polygons are P1; let's also consider polyline-as-input in this ticket as a P2. The primary use case for the latter is pre-caching tiles along a route.

@1ec5
Copy link
Contributor

1ec5 commented Mar 4, 2017

#5707 and #8012 take different approaches to enabling the developer to define an arbitrary shape for offline download.

@kkaefer kkaefer added the Core The cross-platform C++ core, aka mbgl label May 30, 2017
@1ec5
Copy link
Contributor

1ec5 commented Mar 27, 2018

#11447 adds mbgl and Android support for offline regions that cover non-pyramidal geometries.

@1ec5
Copy link
Contributor

1ec5 commented Aug 20, 2018

Fixed in #11447. Thanks @ivovandongen!

@1ec5 1ec5 closed this as completed Aug 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Core The cross-platform C++ core, aka mbgl feature offline
Projects
None yet
Development

No branches or pull requests

5 participants