Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

[ios] Added an optional tile list parameter to MGLTilePyramidOfflineRegion #8012

Closed
wants to merge 1 commit into from

Conversation

wibge
Copy link

@wibge wibge commented Feb 10, 2017

This allows downloading non rectangular map packs, by specifying a specific list of tiles to download. This is useful for downloading along a track or within a polygon area.

@mention-bot
Copy link

@wibge, thanks for your PR! By analyzing this pull request, we identified @1ec5, @boundsj and @incanus to be potential reviewers.

@1ec5 1ec5 added Core The cross-platform C++ core, aka mbgl feature iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS offline labels Feb 10, 2017
Copy link
Contributor

@1ec5 1ec5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR. I’ll leave it to @jfirebaugh to review the mbgl side of this PR.

As for the platform-specific parts, have you considered a subclass or sibling to MGLTilePyramidOfflineRegion that also conforms to the MGLOfflineRegion protocol, such that “tile pyramid” doesn’t become a misnomer?

Copy link
Contributor

@jfirebaugh jfirebaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wibge; this would be a good addition. I agree with @1ec5's suggestion: the core C++ code should define a separate class for this definition type: OfflineTileListRegionDefinition. Unlike OfflineTilePyramidRegionDefinition, it should not have bounds, minZoom, and maxZoom members, since those aren't used when a list of tiles is provided.

@wibge
Copy link
Author

wibge commented Feb 13, 2017

I agree too. I had tried to it originally with proper subclasses, and got a little hung up with the variants. I'll give it a try again now that I'm more familiar with the code.

@wibge wibge force-pushed the download-tile-lists branch from 28d1576 to 1d93d8a Compare July 10, 2017 18:51
@asheemmamoowala
Copy link
Contributor

Addressed by #11447.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Core The cross-platform C++ core, aka mbgl feature iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS offline
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants