Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Integrate node bindings + tests into OS X workspace #4978

Closed
kkaefer opened this issue May 9, 2016 · 7 comments
Closed

Integrate node bindings + tests into OS X workspace #4978

kkaefer opened this issue May 9, 2016 · 7 comments
Labels
Node.js node-mapbox-gl-native

Comments

@kkaefer
Copy link
Contributor

kkaefer commented May 9, 2016

We should integrate the node bindings, and render/query tests into the main OS X workspace to avoid having to have two separate spaces. Since the node bindings depend on the actual node version installed, we should auto-detect the node version from the command line and write the correct settings file.

@1ec5
Copy link
Contributor

1ec5 commented May 9, 2016

Would node be required for developing (say) the OS X SDK?

we should auto-detect the node version from the command line and write the correct settings file.

Note that the workspace file itself is checked in; it isn't generated. So this would be limited to build settings but couldn't affect the project structure.

@1ec5
Copy link
Contributor

1ec5 commented May 9, 2016

For what it's worth, I would also find it more convenient to combine the iOS and OS X workspaces too, since those SDKs share most of their code, but I'm hesitant to bloat the workspace further.

@mikemorris
Copy link
Contributor

We should integrate the node bindings, and render/query tests into the main OS X workspace to avoid having to have two separate spaces.

This would just be to make make xnode cleaner, right? npm install --build-from-source and make node would still work as they currently do?

@mikemorris mikemorris added the Node.js node-mapbox-gl-native label May 9, 2016
@1ec5
Copy link
Contributor

1ec5 commented May 9, 2016

Come to think of it, I think what you’re really asking for is for make xnode to create a node.xcworkspace that has everything, rather than expanding the scope of osx.xcworkspace. Is that correct? These workspaces themselves have next to zero maintenance overhead, thankfully. It’s the Xcode projects that we’d be maintaining, but it sounds like you’d have GYP continue to manage the projects for you, right?

@kkaefer
Copy link
Contributor Author

kkaefer commented May 9, 2016

Yeah, sounds like that's what I want.

@jfirebaugh
Copy link
Contributor

This was done with the switch to cmake, right?

@1ec5
Copy link
Contributor

1ec5 commented Sep 8, 2016

Yes. Fixed in #5359.

@1ec5 1ec5 closed this as completed Sep 8, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Node.js node-mapbox-gl-native
Projects
None yet
Development

No branches or pull requests

4 participants