-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Switch build system to CMake #5359
Conversation
Hahah, wow. |
0fb7f03
to
370c611
Compare
Kudos. |
5d4d83a
to
fa6be53
Compare
Made progress with Qt today. All the configurations, tests, etc work just fine on Linux. https://github.com/mapbox/mapbox-gl-native/tree/tmpsantos-cmake |
Got most of the android build sorted out on: https://github.com/mapbox/mapbox-gl-native/tree/ivovandongen-cmake Links and runs on arm-v5 and arm-v7, but results in linker errors on others still:
|
All ABIs are building now. Also added the copy targets. The libraries are insanely big though, 122MB instead of ~13MB. After reading |
I have been testing with
I did some runs with this on multi devices as:
I also tested out backwards compatibility issues with for arm-v7 on armabi (v5-v6):
Everything is looking 👍 @ivovandongen, |
@tobrun Thanks for the extensive testing! I would also love to have this in one IDE eventually. Need to check out the new experimental gradle plugin. Seems like that is going to be preferred over the "classic" Android.mk. |
@kkaefer @tmpsantos Changes from #5656 got lost in translation, added them back in. I've added them in the android Also, could either of you go over my changes to see if I haven't missed other subtle settings? |
Docs need updated. $ make iproj
mkdir -p build/ios
(cd build/ios && cmake -G Xcode ../.. \
-DCMAKE_TOOLCHAIN_FILE=../../platform/ios/toolchain.cmake \
-DMBGL_PLATFORM=ios)
/bin/sh: cmake: command not found
make: *** [build/ios/mbgl.xcodeproj] Error 127 |
I just updated the install docs to list CMake for all binding flavors. |
@bleege Where are we supposed to install CMake? I'm getting this error:
I've tried install globally too. Well I hacked mbgl.cmake to use /usr/local/lib/node_modules path but now I'm getting this error:
Alternatively if someone could just zip the latests docs for alpha for me plz :) |
revert #28
We want to switch to CMake from gyp because: