Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Remove MGLStyleAttributeFunction.property #6081

Closed
1ec5 opened this issue Aug 18, 2016 · 1 comment
Closed

Remove MGLStyleAttributeFunction.property #6081

1ec5 opened this issue Aug 18, 2016 · 1 comment
Assignees
@1ec5
Labels
iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS refactor runtime styling
Milestone
ios-v3.4.0

Comments

@1ec5
Copy link
Contributor

1ec5 commented Aug 18, 2016 •
edited
Loading

MGLStyleAttributeFunction has a property property that corresponds to Function.property in the style specification. But it’s only used for property functions, which have yet to be ported from GL JS (#4860). We should remove it until property functions are implemented.

Incidentally, when we reintroduce it, it should be called attribute to reduce confusion with Objective-C/Swift properties and for consistency with MGLStyleAttributeValue and MGLStyleAttributeFunction.

/cc @frederoni
@1ec5 1ec5 added iOS Mapbox Maps SDK for iOS refactor macOS Mapbox Maps SDK for macOS runtime styling labels Aug 18, 2016
@1ec5 1ec5 added this to the ios-v3.4.0 milestone Aug 18, 2016
@frederoni frederoni mentioned this issue Aug 19, 2016
Merged
@1ec5 1ec5 self-assigned this Aug 19, 2016
@1ec5
Copy link
Contributor Author

1ec5 commented Aug 19, 2016

Fixed in #6079.

@1ec5 1ec5 closed this as completed Aug 19, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@1ec5 1ec5

Labels
iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS refactor runtime styling
Projects
None yet
Milestone
ios-v3.4.0
Development

No branches or pull requests
1 participant
@1ec5