This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Offsets as vectors, padding as edge insets #6079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1ec5
added
bug
iOS
1ec5
force-pushed
the
1ec5-style-array-5947
branch
2 times, most recently
from
2c24566 to
b231e7c
Compare
|
Note that if a developer is building against the iOS 10 SDK, they can make use of |
1ec5
force-pushed
the
1ec5-style-array-5947
branch
from
b231e7c to
6e8bedb
Compare
|
This PR also fixes #6081 👍 |
Properties representing optional attributes are qualified with null_resettable. The default value is documented.
Also expand values in documentation comments to the full enumeration values. Fixes #5949.
Replaced pixels with points in documentation.
Key the array subtype on the last part of the property name. Don’t assume one of the unaccounted-for properties is an offset.
null_resettable semantics aren’t currently respected: #6095.
An offset style attribute is now exposed publicly as an NSValue representing a CGVector instead of an NSArray of NSNumbers. A padding style attribute is now exposed publicly as an NSValue representing an NSEdgeInsets or UIEdgeInsets instead of an NSArray of NSNumbers. This change also fixes round-tripping of padding values due to a difference between the style specification and Foundation regarding the order of edges around a box. Used a designated initializer on NSEdgeInsets/UIEdgeInsets to ensure correct order when converting from C++ to Objective-C. Fixes #5947, fixes #6065.
Edges shouldn’t be able to cancel out other edges, so a summation is inappropriate here.
1ec5
force-pushed
the
1ec5-style-array-5947
branch
from
67edd60 to
98c6987
Compare
This was referenced Aug 19, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An offset style attribute is now exposed publicly as an NSValue representing a
CGVectorinstead of an NSArray of NSNumbers. Likewise, a padding style attribute is now exposed publicly as an NSValue representing anNSEdgeInsetsorUIEdgeInsetsinstead of an NSArray of NSNumbers.This change also fixes round-tripping of padding values due to a difference between the style specification and Foundation regarding the order of edges around a box. It uses a designated initializer on
NSEdgeInsets/UIEdgeInsetsto ensure correct order when converting from C++ to Objective-C.Fixes #5947, fixes #6065. Depends on #6076.
/cc @frederoni