Various features render with wrong color on some Android GPUs

[nitrag]

Platform: Android
Mapbox SDK version: 5.0.0-SNAPSHOT

1. App uninstall/reinstall has no effect.
2. Works fine on other devices.

[tobrun]

@nitrag thank you for letting us know that the Samsung Galaxy J3 2016 has rendering issues. Do you know if older versions of the SDK rendered correctly on this device?

[nitrag]

@tobrun I can confirm in a barebone app test project that the problem arose when moving to 5.0.0-beta3. Beta2 is working fine.

EDIT: BTW, Also worked fine 4.2.2 (stable).

[tobrun]

capturing from chat with @zugaldia that the issue only reproduces on one device and thus isn't a release blocker. Going to remove the label. This doesn't take away that this is a bug that should be looked into.

[tobrun]

I was able to purchase the European equivalent of the mentioned A&T phone,
though there isn't an Android 6.0.1 update for it yet:

[tobrun]

Not able reproducing the render issue on this device:

@nitrag any more information on this to move forward? Are you aware of any other devices with this issue?

[nitrag]

Can you share this Simple Map project I want to be sure it's exact. Is there some kind of advanced debugging I can enable in case there is a style error? I will do some further testing today.

…

On Thu, Mar 16, 2017 at 4:43 AM Tobrun ***@***.***> wrote: Not able reproducing the render issue on this device: [image: ezgif com-video-to-gif 22] <https://cloud.githubusercontent.com/assets/2151639/23988058/dfd7ee8a-0a2c-11e7-9ae7-3d886f548690.gif> @nitrag <https://github.com/nitrag> any more information on this to move forward? Are you aware of any other devices with this issue? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#8385 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAMBkp_1A9Nfv8Y-TMHyBjdO3YheLxFbks5rmPY0gaJpZM4McKXT> .

[tobrun]

This was produced with the Simple Map Activity found in this repo, you can test with latest snapshot by replacing:

    compile(project(':MapboxGLAndroidSDK')) {
        transitive = true
    }

with the snapshot build in case you don't want to go through the trouble of building the C++ code yourself. Feel free to share your style so we can try reproducing it with the style from OP.

[jfirebaugh]

Given that the regression occurred between 5.0.0-beta2 and 5.0.0-beta3 and is GPU-specific, it was likely caused by 692f5e0.

[jfirebaugh]

All color pragmas (e.g. here) need to use highp.

cc @anandthakker

[jfirebaugh]

A speculative fix has been merged to the release-ios-v3.5.0-android-v5.0.0 branch. Next step is to confirm it resolves the issue by testing a build from this branch on an affected device.

[nitrag]

I'm not too Android savvy and wasn't successful building the SDK from source last time I tried. Can someone build it from source for me? Happy to test.

[zugaldia]

Thanks @nitrag. I ran the updated branch on one of the affected devices, a Galaxy S6 Edge API Level 22 (via Firebase). This is the current rendering:

And this was the rendering, on the same device, before the fix:

This seems to confirm the fix is working. Next, we're releasing 5.0.1 including just this fix.

[nitrag]

Ok great! I'll confirm once I see 5.0.1 published.

[zugaldia]

@nitrag 5.0.1 has been published #8501, could you check if you still see the rendering issue?

[snowpong]

@zugaldia Fixes rendering issues for me. Attached screenshots #8501 (comment) (sorry, probably should have attached them here)

[tobrun]

Thanks for confirming @snowpong, closing.

[nitrag]

Confirming as well. Thanks!

…

On Thu, Mar 23, 2017 at 8:03 AM Tobrun ***@***.***> wrote: Thank for confirming @snowpong <https://github.com/snowpong>, closing. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#8385 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAMBkq_ljOff2AStKy982jKpeJugz0Lxks5rol-fgaJpZM4McKXT> .

[zugaldia]

@nitrag Thank you for checking!