Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Remove deprecated notifyMapChange #8389

Closed
tobrun opened this issue Mar 14, 2017 · 5 comments
Closed

Remove deprecated notifyMapChange #8389

tobrun opened this issue Mar 14, 2017 · 5 comments
Assignees
@tobrun
Labels
Android Mapbox Maps SDK for Android

Comments

@tobrun
Copy link
Member

tobrun commented Mar 14, 2017

PR in #8377 introduced a MapObserver in core with dedicated callback methods for each type of map change event. Our current implementation of notifyMapChange was deprecated and we should migrate to this new system.
@tobrun tobrun added Android Mapbox Maps SDK for Android SEMVER-MAJOR Requires a major release according to Semantic Versioning rules labels Mar 14, 2017
@brunoabinader brunoabinader mentioned this issue Mar 14, 2017
Merged
@brunoabinader
Copy link
Member

Worth noticing that once the NativeMapView no longer depens on mbgl::MapChange, we can safely remove src/mbgl/map/change.hpp.

@tobrun
Copy link
Member Author

tobrun commented Mar 16, 2017

A follow up PR in #8418 from @brunoabinader now also provides some additional error logging when a Map fails to load. While fixing up this issue we look into exposing that API for end developers as current implementation isn't very visible/discoverable for them.

@brunoabinader
Copy link
Member

FWIW #8443 replaces onSourceDidChange with onSourceAttributionChanged passing both sourceID and attribution.

@tobrun tobrun mentioned this issue May 15, 2017
Closed
@tobrun tobrun mentioned this issue Jul 11, 2017
Closed
@tobrun
Copy link
Member Author

tobrun commented Jul 12, 2017

I'm removing the semver-major as we could internally integrate this and keep exposing our public API around MapChange events. The internal integration will help improving gesture performance as noted in #9476.

@tobrun tobrun removed the SEMVER-MAJOR Requires a major release according to Semantic Versioning rules label Jul 12, 2017
@tobrun tobrun added this to the android-v5.2.0 milestone Jul 12, 2017
@tobrun tobrun mentioned this issue Jul 13, 2017
Closed
10 tasks
@tobrun tobrun self-assigned this Sep 25, 2017
@lilykaiser lilykaiser removed this from the android-v5.2.0 milestone Nov 16, 2017
@tobrun
Copy link
Member Author

tobrun commented Oct 24, 2018

This has been handled in #13050

@tobrun tobrun closed this as completed Oct 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@tobrun tobrun

Labels
Android Mapbox Maps SDK for Android
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@brunoabinader @tobrun @lilykaiser