This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Replace OnMapChange with specific callbacks #13050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@LukasPaczos this PR is ready for review:
|
tobrun
force-pushed
the
tvn-map-change
branch
2 times, most recently
from
89fc4fc
to
492a64d
Compare
LukasPaczos
reviewed
Oct 10, 2018
| @@ -159,7 +159,7 @@ void onRestoreInstanceState(@NonNull Bundle savedInstanceState) { | |||
| } | |||
|
|
|||
| /** | |||
| * Called when the hosting Activity/Fragment onDestroy()/onDestroyView() method is called. | |||
| * Called when the hosting Activity/Fragment clear()/onDestroyView() method is called. | |||
| @@ -116,7 +122,7 @@ private boolean checkState(String callingMethod) { | |||
| // validate if map has already been destroyed | |||
| if (destroyed && !TextUtils.isEmpty(callingMethod)) { | |||
| String message = String.format( | |||
| "You're calling `%s` after the `MapView` was destroyed, were you invoking it after `onDestroy()`?", | |||
| "You're calling `%s` after the `MapView` was destroyed, were you invoking it after `clear()`?", | |||
| @@ -417,11 +422,12 @@ public void onStop() { | |||
| } | |||
|
|
|||
| /** | |||
| * You must call this method from the parent's Activity#onDestroy() or Fragment#onDestroyView(). | |||
| * You must call this method from the parent's Activity#clear() or Fragment#onDestroyView(). | |||
tobrun
force-pushed
the
tvn-map-change
branch
from
492a64d
to
80ec30d
Compare
|
double checked refactor artefacts and should be addressed with 80ec30d |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR introduces separate callbacks for all the map change events instead of wiring them through the same OnMapChange callback. This avoids iterating all registered listener and limits the invocations of those callbacks for non-related events.
This PR also aligns naming of callbacks to match core naming more closely:
Todo:
native_map_view.cppchangesReplaces obsolete closed PR in #9498.