Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Replace Toolbar With ActionBar / AppBar In GLTestApp #933

Closed
bleege opened this issue Mar 2, 2015 · 3 comments
Closed

Replace Toolbar With ActionBar / AppBar In GLTestApp #933

bleege opened this issue Mar 2, 2015 · 3 comments
Labels
Android Mapbox Maps SDK for Android

Comments

@bleege
Copy link
Contributor

bleege commented Mar 2, 2015

The current test app makes use of a Toolbar on top of the existing ActionBar. Let's go with the ActionBar on it's own as it offers more builtin features out of the box that will make adding features easier in the future.

http://www.google.com/design/spec/layout/structure.html

@bleege bleege added the Android Mapbox Maps SDK for Android label Mar 2, 2015
@ljbade
Copy link
Contributor

ljbade commented Mar 2, 2015

Interesting. The reason I went with the toolbar is that it appears to be the proper way to have action buttons that can overflow into the drop menu.

Perhaps Google have changed the way ActionBar stuff is supposed to behave in Android 5?

Also while you are at it you might as well make the GPS button a proper toggle button control instead of the manual toggle I have.

@ljbade
Copy link
Contributor

ljbade commented Jul 28, 2015

@bleege Did you do this in the Activity change?

@bleege
Copy link
Contributor Author

bleege commented Jul 28, 2015

This will implemented via Material Design refactor in #1856.

@bleege bleege closed this as completed Jul 28, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android
Projects
None yet
Development

No branches or pull requests

2 participants