Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

API for platform side animations #10001

Merged
merged 1 commit into from
Sep 26, 2017
Merged

Conversation

tobrun
Copy link
Member

@tobrun tobrun commented Sep 14, 2017

Closes #8175, Refs #9808, this PR adds a simple camera API on MapboxMap that can be used in combination with Android SDK animators to perform animations as shown in #9808 (comment).

ezgif com-video-to-gif 26

@tobrun tobrun added the Android Mapbox Maps SDK for Android label Sep 14, 2017
@tobrun tobrun added this to the android-v5.2.0 milestone Sep 14, 2017
@tobrun tobrun self-assigned this Sep 14, 2017
@tobrun tobrun force-pushed the 9808-platform-animation-android branch from ac6197f to 63f4390 Compare September 15, 2017 10:06
@tobrun
Copy link
Member Author

tobrun commented Sep 18, 2017

Remaining TODO is look into using a dynamic focal point

@tobrun tobrun force-pushed the 9808-platform-animation-android branch from 63f4390 to 035c886 Compare September 21, 2017 06:37
@tobrun
Copy link
Member Author

tobrun commented Sep 21, 2017

#10001 (comment) has been resolved with 035c886

@tobrun tobrun force-pushed the 9808-platform-animation-android branch from 035c886 to 8125fd0 Compare September 26, 2017 07:27
@tobrun
Copy link
Member Author

tobrun commented Sep 26, 2017

@Guardiola31337 @zugaldia can I get a review on this?

Copy link
Contributor

@Guardiola31337 Guardiola31337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A Wear file has crept here 😬
Apart from that, looks good to me 👍

@@ -0,0 +1,4 @@
<?xml version="1.0" encoding="utf-8"?>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This MapboxGLAndroidSDKWearTestApp file has crept in this PR 😬

@tobrun tobrun force-pushed the 9808-platform-animation-android branch from 8125fd0 to 053e265 Compare September 26, 2017 08:58
@tobrun
Copy link
Member Author

tobrun commented Sep 26, 2017

Thank you for catching that!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants