This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Testapp cleanup #10006
Merged
Testapp cleanup #10006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
tobrun
commented
Sep 15, 2017
tobrun
commented
- move strings resources to dedicated files
- fixup simple map activity
- fixup double map activity
- snapshot activity home button click fix
- add activity titles,
- remove obsolete navigation drawer activity
Guardiola31337
approved these changes
Sep 18, 2017
| @@ -18,6 +18,9 @@ | |||
| import com.mapbox.mapboxsdk.testapp.model.annotations.CityStateMarkerOptions; | |||
| import com.mapbox.mapboxsdk.testapp.utils.IconUtils; | |||
|
|
|||
| /** | |||
| * Test activity showcasing using in InfoWindowAdapter to provide a custom InfoWindow content. | |||
There was a problem hiding this comment.
NIT typo *in should be an.
| @@ -23,6 +22,12 @@ | |||
| import com.mapbox.mapboxsdk.maps.UiSettings; | |||
| import com.mapbox.mapboxsdk.testapp.R; | |||
|
|
|||
| /** | |||
| * Test activity showcasing showing 2 maps on top of each other. | |||
There was a problem hiding this comment.
NIT showcasing showing sounds strange to me.
…ap activity, fixup double map activity, snapshot activity home button click fix, add activity titles, remove obsolete navigation drawer activity
tobrun
force-pushed
the
tvn-testapp-fixes
branch
from
79349f8
to
2670130
Compare
20 tasks
20 tasks
20 tasks
This was referenced Nov 14, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.