Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

[android] Hook camera events into compass #10019

Merged
merged 1 commit into from
Sep 20, 2017
Merged

[android] Hook camera events into compass #10019

merged 1 commit into from
Sep 20, 2017

Conversation

Guardiola31337
Copy link
Contributor

👀 @tobrun

@Guardiola31337 Guardiola31337 added the Android Mapbox Maps SDK for Android label Sep 18, 2017
@Guardiola31337 Guardiola31337 added this to the android-v5.2.0 milestone Sep 18, 2017
tobrun
tobrun approved these changes Sep 19, 2017
View reviewed changes
Copy link
Member

@tobrun tobrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good, though would love to know the intensive of moving click handling to MapView. It was placed in CompassView to encapsulate that behavior.

@Guardiola31337
Copy link
Contributor Author

@tobrun

though would love to know the intensive of moving click handling to MapView. It was placed in CompassView to encapsulate that behavior.

Wasn't 👉 https://github.com/mapbox/mapbox-gl-native/pull/10019/files#diff-134d85017f67b51137a7371964f3aa52L65 referring to that? Probably I misunderstood. I'll revert those changes.

@tobrun
Copy link
Member

tobrun commented Sep 19, 2017

I'm 👍 on the change, was just wondering. Re. that todo, was more about replacing Mapbox with transform but this also works 😉

@Guardiola31337 Guardiola31337 merged commit 2fcbd78 into master Sep 20, 2017
@Guardiola31337 Guardiola31337 deleted the pg-compass-camera-events branch September 20, 2017 08:16
@Guardiola31337 Guardiola31337 mentioned this pull request Oct 6, 2017
Closed
20 tasks
@Guardiola31337 Guardiola31337 mentioned this pull request Oct 19, 2017
Closed
20 tasks
@Guardiola31337 Guardiola31337 mentioned this pull request Oct 26, 2017
Closed
20 tasks
@tobrun tobrun mentioned this pull request Nov 3, 2017
Closed
21 tasks
This was referenced Nov 14, 2017
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tobrun tobrun tobrun approved these changes

Assignees

@Guardiola31337 Guardiola31337

Labels
Android Mapbox Maps SDK for Android
Projects
None yet
Milestone
android-v5.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Guardiola31337 @tobrun