This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[android] - Add touch velocity effects on scale and rotation gesture. #10110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rooholam thank you for this contribution, putting on my radar to review, this is definitely an UX that we are considering to add (similar for rotation and other gestures). |
rooholam
changed the title
|
@tobrun I committed codes for rotating gesture too. |
|
@rooholam tested this out and this is a great start! We might need to fine-tune a couple of things before we will merge this (eg. the focal point used when the velocity animation starts) but thank you for this contribution! Note we might bring this functionality at the same time as we replace the animations with Android SDK animators. |
|
I've pulled in the changesd in #10202 and work further from there to integrate these changes in the SDK. Thanks again for the contribution. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Track fingers velocity for scale and rotation gesture.