This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[core] Update glyph requestors _before_ requesting from file source #10153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @bsudekum |
brunoabinader
force-pushed
the
update-glyph-requestors
branch
from
a5a3170
to
1876557
Compare
tmpsantos
approved these changes
Oct 9, 2017
Closed
|
What file sources are returning results synchronously? f053feb is supposed to prevent that. |
I believe this situation can happen when we replace the original |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the file source request happens immediately (e.g. when obtaining from a memory cache), then the glyph manager response processing happens before the glyph requestors map gets updated, causing the notification to never happen in such cases.