-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Conversation
What’s the implication of limiting the annotation tile zoom level? Just that point and shape annotation coordinates will be simplified to z16 and overzoomed after that, correct? Would it be possible to dynamically match the maximum maxzoom of the current non-annotation sources? |
e8ce4ab
to
f3285d2
Compare
The maximum zoom level was increased to z22 in #5517. (I found it because we happened to mention it in the iOS SDK changelog, but I don’t know that any developer is terribly dependent on this behavior.) |
I have the same questions as @1ec5. |
Yeah, annotations will only exist up to z16, and we will overzoom tiles from there on. @GretaCB has a great explanation in https://github.com/mapbox/vector-tiles/issues/45#issuecomment-325781516 of why z16 is sufficient for those tiles.
We could, however, expose the maxzoom as a property for the annotations source, so that you could modify this at runtime. |
I think we'll get that already when refactoring annotations based on runtime styling. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mind adding something to the iOS and macOS changelogs about this fix?
f3285d2
to
53776eb
Compare
Technically, this is an internal change that shouldn't affect external behavior, so I'm hesitant to add a changelog item. We're not really exposing the concept of tiles in the context of annotations to the end user so far. |
We're currently generating annotation tiles all the way up to z22:
mapbox-gl-native/src/mbgl/annotation/render_annotation_source.cpp
Line 41 in 2166b85
In most cases, however, it's unnecessary to regenerate the tiles for higher zoom levels. We should limit the tiles to z16 to match the tile level most vector tilesets use as well.