Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Limit annotation tiles to z16 #10197

Merged
merged 1 commit into from
Oct 19, 2017
Merged

Conversation

kkaefer
Copy link
Member

@kkaefer kkaefer commented Oct 13, 2017

We're currently generating annotation tiles all the way up to z22:

In most cases, however, it's unnecessary to regenerate the tiles for higher zoom levels. We should limit the tiles to z16 to match the tile level most vector tilesets use as well.

@1ec5
Copy link
Contributor

1ec5 commented Oct 13, 2017

What’s the implication of limiting the annotation tile zoom level? Just that point and shape annotation coordinates will be simplified to z16 and overzoomed after that, correct?

Would it be possible to dynamically match the maximum maxzoom of the current non-annotation sources?

@kkaefer kkaefer force-pushed the 10197-limit-annotation-source-to-z16 branch from e8ce4ab to f3285d2 Compare October 13, 2017 23:43
@1ec5
Copy link
Contributor

1ec5 commented Oct 13, 2017

The maximum zoom level was increased to z22 in #5517. (I found it because we happened to mention it in the iOS SDK changelog, but I don’t know that any developer is terribly dependent on this behavior.)

@1ec5 1ec5 added annotations Annotations on iOS and macOS or markers on Android Core The cross-platform C++ core, aka mbgl labels Oct 13, 2017
@lilykaiser lilykaiser added this to the android-v5.1.5 milestone Oct 17, 2017
@jfirebaugh
Copy link
Contributor

I have the same questions as @1ec5.

@kkaefer
Copy link
Member Author

kkaefer commented Oct 17, 2017

Yeah, annotations will only exist up to z16, and we will overzoom tiles from there on. @GretaCB has a great explanation in https://github.com/mapbox/vector-tiles/issues/45#issuecomment-325781516 of why z16 is sufficient for those tiles.

Would it be possible to dynamically match the maximum maxzoom of the current non-annotation sources?
We could do that, but then we couldn't guarantee accuracy of annotations anymore. E.g. if you only have another source that uses 0-8, overzoom those tiles, then annotation tiles would also be limited to z8, which might produce precision issues.

We could, however, expose the maxzoom as a property for the annotations source, so that you could modify this at runtime.

@brunoabinader
Copy link
Member

We could, however, expose the maxzoom as a property for the annotations source, so that you could modify this at runtime.

I think we'll get that already when refactoring annotations based on runtime styling.

@kkaefer kkaefer modified the milestones: android-v5.1.5, android-future Oct 18, 2017
Copy link
Contributor

@1ec5 1ec5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mind adding something to the iOS and macOS changelogs about this fix?

@kkaefer kkaefer force-pushed the 10197-limit-annotation-source-to-z16 branch from f3285d2 to 53776eb Compare October 18, 2017 22:51
@kkaefer
Copy link
Member Author

kkaefer commented Oct 18, 2017

Mind adding something to the iOS and macOS changelogs about this fix?

Technically, this is an internal change that shouldn't affect external behavior, so I'm hesitant to add a changelog item. We're not really exposing the concept of tiles in the context of annotations to the end user so far.

@kkaefer kkaefer merged commit 60d6356 into master Oct 19, 2017
@kkaefer kkaefer deleted the 10197-limit-annotation-source-to-z16 branch October 19, 2017 16:22
@lilykaiser lilykaiser removed this from the android-future milestone Oct 23, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
annotations Annotations on iOS and macOS or markers on Android Core The cross-platform C++ core, aka mbgl
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants