Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

[TMP] Check moto x crash with sanitizers and valgrind #10233

Closed
wants to merge 1 commit into from

Conversation

@ivovandongen ivovandongen added the ⚠️ DO NOT MERGE Work in progress, proof of concept, or on hold label Oct 19, 2017
@ivovandongen ivovandongen self-assigned this Oct 19, 2017
@ivovandongen
Copy link
Contributor Author

@jfirebaugh @ChrisLoer Ran the sanitizers on this test case

undefined.txt
thread.txt
address.txt

@ivovandongen
Copy link
Contributor Author

Bisected the issue.

There are only 'skip'ped commits left to test.
The first bad commit could be any of:
7c7564d72ed060bfd9ff1d5ebc6086a52f837c4b
8c23f14a9f47bc3e2d687ed25561b586643348f5
72f6b73590722d5451623cd21c4b1abde74e8f69
f8402e20425cee6cbad2a28809bce17ac46c1379
2ee59796fb47c3152b2bdcfa5cde4be5a92316b4
a432a289a35815beeadc8719a963f50f8dc07bbb
7b29b90e7fb379ca4f592e98fd3144d424937632
a0e37fe35b1af9f607600d2e792e2ff56796af6e
77734cfe1b9e77a0058fa3e0db79e3c20a264165
8f5e0b66ab13cff7d35ed46afaddbdca9ab1993f
e514138b691615be24f484986c40f486223df82a
We cannot bisect more!

@ivovandongen
Copy link
Contributor Author

#9009 seems to have introduced the issue

@ivovandongen
Copy link
Contributor Author

Tried:

  • Removing the glBufferSubData call -> no crash
  • Going from glBufferSubData to glBufferData on updates -> crash
  • Using GL_STATIC_DRAW -> crash
  • Using a newly created vertex vector of the same length with empty elements -> crash
  • Not binding the VertexBuffer passed in -> no crash, obviously renders weirdly
  • Creating a new VertexBuffer -> no crash

Typical run, logging the creation and updating of the vertex buffers for line text:

Created buffer: 7 of size: 12288
Updating buffer: 7 of size: 12288
Created buffer: 10 of size: 13872
Created buffer: 13 of size: 11376
Updating buffer: 10 of size: 13872
Updating buffer: 7 of size: 12288
Updating buffer: 13 of size: 11376
Created buffer: 16 of size: 13440
Updating buffer: 10 of size: 13872
Updating buffer: 7 of size: 12288
Updating buffer: 16 of size: 13440
Updating buffer: 13 of size: 11376
Updating buffer: 10 of size: 13872
Updating buffer: 7 of size: 12288
Updating buffer: 16 of size: 13440
Updating buffer: 13 of size: 11376
Updating buffer: 10 of size: 13872
Updating buffer: 7 of size: 12288
Updating buffer: 16 of size: 13440
Updating buffer: 13 of size: 11376
Created buffer: 19 of size: 12288
Updating buffer: 10 of size: 13872
Updating buffer: 19 of size: 12288
Updating buffer: 16 of size: 13440
Updating buffer: 13 of size: 11376
Created buffer: 22 of size: 13152
Updating buffer: 22 of size: 13152
Updating buffer: 19 of size: 12288
Updating buffer: 16 of size: 13440
Updating buffer: 13 of size: 11376

The number of updates to the same buffer, the number of buffers created, the size of the buffer are all not fixed between manual runs.

@jfirebaugh jfirebaugh closed this Oct 24, 2017
@jfirebaugh jfirebaugh deleted the ivd-test-motox branch October 24, 2017 20:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
⚠️ DO NOT MERGE Work in progress, proof of concept, or on hold
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants