This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[ios] Fix iOS 8 incompatibility in scale bar RTL check #10241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -165,7 +165,9 @@ - (void)viewDidLoad | |||
| self.mapView.scaleBar.hidden = NO; | |||
| self.mapView.showsUserHeadingIndicator = YES; | |||
| self.hudLabel.hidden = YES; | |||
| self.hudLabel.titleLabel.font = [UIFont monospacedDigitSystemFontOfSize:10 weight:UIFontWeightRegular]; | |||
| if ([UIFont respondsToSelector:@selector(monospacedDigitSystemFontOfSize:weight:)]) { | |||
There was a problem hiding this comment.
For iOS 8 which would be the font alternative?
There was a problem hiding this comment.
It’s set to use the system font of the same size, via the storyboard.
frederoni
approved these changes
Oct 20, 2017
friedbunny
force-pushed
the
fb-scalebar-ios8-fix
branch
from
8217e31 to
00e44e9
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10225 by checking to see if
UIView.semanticContentAttributeis available before using it in-[MGLScaleBar usesRightToLeftLayout]. This now falls back toUIApplication.userInterfaceLayoutDirectionin iOS 8.Also fixes an issue in iosapp where
-[UIFont monospacedDigitSystemFontOfSize:weight:]wasn’t available in iOS 8./cc @frederoni @fabian-guerra