This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Move shape annotation click handling to core #10267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Guardiola31337
approved these changes
Oct 26, 2017
| @Override | ||
| public List<Annotation> obtainAllIn(RectF rectangle) { | ||
| // convert Rectangle to be density dependant | ||
| float pixelRatio = nativeMapView.getPixelRatio(); |
There was a problem hiding this comment.
What about extracting // convert Rectangle to be density dependant block of code into a private method?
There was a problem hiding this comment.
👍, instead of private, I moved it to NativeMapView and refactored similar code for DRY reasons.
| rectangle.right / pixelRatio, | ||
| rectangle.bottom / pixelRatio); | ||
|
|
||
| List<Annotation> shapeAnnotations = new ArrayList<>(); |
There was a problem hiding this comment.
Same here ☝️ when getting the list of shapeAnnotations.
tobrun
force-pushed
the
10234-query-shape-annotations
branch
from
d787edf to
c7a9108
Compare
This was referenced Oct 30, 2017
This was referenced Nov 14, 2017
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10234, refs #9984 and #9443.
This moves the logic as shown in #9984 to core.