Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

[build] Add CircleCI iOS & macOS builds (master branch) #10289

Closed
wants to merge 0 commits into from

Conversation

friedbunny
Copy link
Contributor

@friedbunny friedbunny commented Oct 25, 2017

Cherry-picks #10257 into master. This replaces the Bitrise iOS and macOS builds with improved versions on CircleCI.

Note that this does not replace the macOS-based Bitrise Node and Qt builds — for that, see #10278.

Once this PR is merged, we should:

  • Un-require the Bitrise iOS and Bitrise macOS builds on GitHub.
  • Require the three new CircleCI builds (ios-debug, ios-sanitize-thread, and macos-debug) on GitHub.

After this is merged, if you find that your PR fails to start some required tests: rebase onto master to bring in these changes.

/cc @mapbox/gl-core @mapbox/android @mapbox/ios

@friedbunny friedbunny added build iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS labels Oct 25, 2017
@friedbunny friedbunny self-assigned this Oct 25, 2017
@friedbunny
Copy link
Contributor Author

friedbunny commented Oct 25, 2017

The new builds are failing because #10190 isn’t in master yet:

- missing symbol export for class MGLMapSnapshotOptions in platform/darwin/src/MGLMapSnapshotter.h:12:12

@fabian-guerra @tobrun Have we thought about merging release-agua back to master (now that beta 2 is released), or should I just cherry-pick what I need?

@friedbunny
Copy link
Contributor Author

friedbunny commented Oct 27, 2017

Holding on this until after ios-v3.7.0-beta.3 is tagged and merged back to master.

@brunoabinader
Copy link
Member

Holding on this until after ios-v3.7.0-beta.3 is tagged and merged back to master.

This is now done via #10421.

@1ec5
Copy link
Contributor

1ec5 commented Nov 10, 2017

#10257 itself was merged back to master, so this PR is no longer necessary per se. However, the GitHub hooks still need to be updated to require CircleCI instead of Bitrise.

@friedbunny friedbunny closed this Nov 16, 2017
@friedbunny friedbunny force-pushed the fb-macos-circleci-master branch from 3440dd4 to dcd7da1 Compare November 16, 2017 22:02
@friedbunny friedbunny deleted the fb-macos-circleci-master branch November 16, 2017 22:02
@friedbunny
Copy link
Contributor Author

friedbunny commented Nov 16, 2017

  • The three new CircleCI builds (ios-debug, ios-sanitize-thread, and macos-debug) are now required on the master branch.
  • The iOS and macOS Bitrise builds are un-required on master and will always pass.
  • There are two remaining builds on Bitrise (macOS-based node and Qt) — for the migration of those, see [build] Add CircleCI Qt & Node macOS builds #10278.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
build iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants