This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[ios] Fix image property of MGLAnnotationImage does not update. #10372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This fixes #4556. |
fabian-guerra
force-pushed
the
fabian-annotation-image-4556
branch
from
becf7a0 to
1354a71
Compare
1ec5
approved these changes
Jan 10, 2018
There was a problem hiding this comment.
Based on my earlier experiment in #4556 (comment) and the followup in #4556 (comment), I feel fairly confident that this is the right fix, in that it forces mbgl to go down the image replacement code path. Good to merge after performing some sanity checking in iosapp.
|
This is worth a changelog entry, by the way. |
|
We will target boba release and include a test case before merging. |
fabian-guerra
force-pushed
the
fabian-annotation-image-4556
branch
from
1354a71 to
46bb79e
Compare
fabian-guerra
force-pushed
the
fabian-annotation-image-4556
branch
from
46bb79e to
67b9eb9
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4556