This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Activate filesource to list offline regions #10531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zugaldia
approved these changes
Nov 22, 2017
osana
reviewed
Nov 23, 2017
| listOfflineRegions(fileSource, new ListOfflineRegionsCallback() { | ||
|
|
||
| @Override | ||
| public void onList(final OfflineRegion[] offlineRegions) { | ||
| getHandler().post(new Runnable() { | ||
| @Override | ||
| public void run() { | ||
| fileSource.deactivate(); | ||
| callback.onList(offlineRegions); | ||
| } |
There was a problem hiding this comment.
Should fileSource.deactivate();
happen after the callback.onList(offlineRegions); ?
There was a problem hiding this comment.
I rebased osana-offline branch and was not able to see listed offline regions any more.
Reversing the order - fixed my issue
There was a problem hiding this comment.
I rebased osana-offline branch and was not able to see listed offline regions any more.
Reversing the order - fixed my issue
startled that this is the case, could you follow up in your branch with reversing?
There was a problem hiding this comment.
I updated the branch with that change.
| @@ -168,6 +169,7 @@ public void onError(final String error) { | |||
| getHandler().post(new Runnable() { | |||
| @Override | |||
| public void run() { | |||
| fileSource.deactivate(); | |||
There was a problem hiding this comment.
Probably we should do the callback first and then deactivate the fileSource
tobrun
added a commit
that referenced
this pull request
Dec 5, 2017
tobrun
added a commit
that referenced
this pull request
Dec 6, 2017
mappy-mobile
pushed a commit
to Mappy/mapbox-gl-native
that referenced
this pull request
Dec 11, 2017
* mapbox_release5.2.1: (29 commits) [android] - update changelog for 5.2.1 release [ios, macos] Rename the iOS and macOS SDKs (mapbox#10610) [core, ios, qt, android] Close race condition in RunLoop (issue mapbox#9620) Because a message we queue from the foreground may cause the background to complete, exit, and tear down the AsyncTask, we have to block queue processing until we've finished our call to AsyncTask::send(). Broadening the scope of a mutex is scary, but I audited the code of our four implementations of AsyncTask and I don't see any way this could cause a deadlock. [android] - add FileSource activation/deactivation to MapSnapshotter, handle multiple deactivate scenario in FileSource (mapbox#10556) [android] - handle destroying activity programmatically as part of theme switching (mapbox#10589) [android] - use concurrent lists for camera change listeners (mapbox#10542) [android] - harden MarkerView integration by checking for null bitmap (mapbox#10532) [android] - activate filesource to list offline regions (mapbox#10531) [android] Enable map rendering when app is paused [ios, macos] Snapshot classes added to jazzy [android] remove unnecessary jar generation from gradle-publish.gradle (mapbox#10625) [ios, macos] Refactor snapshot attribution. [macos] Fixed logo view distortion on macOS High Sierra [ios, macos] Update changelogs. [ios, macos] Fix an issue that triggers didSelectAnnotations for MGLAnnotationImage based annotations. [ios] Fix minimumZoomLevel is not getting set. [android] - attribtuion anchor point calculation fix for short text with full logo on a MapSnapshot (mapbox#10558) [android] use location engine abstraction instead of location source (lost) in MyLocationView#init (mapbox#10579) [build] Added CircleCI macos-release-node{4,6} jobs [android] Set a larger limit for the HTTP dispatcher (mapbox#10567) ... # Conflicts: # platform/android/CHANGELOG.md # platform/android/MapboxGLAndroidSDK/gradle-publish.gradle # platform/android/MapboxGLAndroidSDK/gradle.properties
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #10470