This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[android] Agua cherry-pick of TinySDF functionality #10706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc: @mapbox/maps-android |
- Platform-specific LocalGlyphRasterizer is responsible for deciding which glyphs to rasterize locally and for implementing the rasterization. - Default platform implementation doesn't locally generate any glyphs -> no behavior change - Unit test uses StubLocalGlyphRasterizer, which returns a single fixed bitmap for all CJK glyphs - Rename glyph_loader.test to glyph_manager.test
- Draws bold version of glyph if font stack contains string "bold" - Not hooked up to global configuration yet
ChrisLoer
force-pushed
the
android-agua-tinysdf
branch
from
6c0bd52 to
218dcf2
Compare
|
I ended up stripping the PR back a little further:
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cherry picks core/android TinySDF functionality from
master. It also contains the initial ios/macos implementation because that commit made significant changes to core, but does not include all the follow-up commits that actually enable the functionality on ios/macos. It includes the core test for TinySDF, but does not include the unit tests that actually do local glyph generation (they only ran on macOS).I tested by building the test app and running the "Local CJK glyphs" test activity in a Pixel emulator.
In general I tried to keep the commits as minimally modified as possible, hoping that will reduce pain during the eventual merge back to master. If it helps, I can re-write the ios/macos commit to strip out the darwin-specific parts of the code.
/cc @zugaldia @chriswu42 @lilykaiser @Guardiola31337 @ivovandongen