This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Inconsistent parameters to LatLngBounds.union #10728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osana
force-pushed
the
osana-valid-bounds
branch
from
3105c50 to
aea44fa
Compare
osana
changed the title
tobrun
approved these changes
Dec 19, 2017
osana
force-pushed
the
osana-valid-bounds
branch
from
aea44fa to
f1b6e45
Compare
|
closes #10728 |
|
closes #10727 |
23 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not sure if we can change the API for union() to be consistent with the rest of LatLngBounds class.
union(LatLngBounds) renamed the variables to reflect what is being passed. Lon and lat were switched.