This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Hardening map destruction #10811
Merged
Hardening map destruction #10811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobrun
force-pushed
the
tvn-destroy-map
branch
from
ff03e16 to
1cbb897
Compare
LukasPaczos
approved these changes
Jan 2, 2018
| } | ||
|
|
||
| nativeMapView = new NativeMapView(this, mapRenderer); | ||
| nativeMapView.resizeView(getMeasuredWidth(), getMeasuredHeight()); | ||
| } | ||
|
|
||
| private void initRenderSurface() { |
There was a problem hiding this comment.
Small nit. But could we rename this to something like onSurfaceCreated? It doesn't really initialise the render surface.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up from #10804.
Fixes #10563.
cc @hashfunction