This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Add orientation change regression test #10814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobrun
force-pushed
the
tvn-orientation-test
branch
from
c4eb828
to
faa34d6
Compare
LukasPaczos
suggested changes
Jan 2, 2018
| public static ViewAction orientationPortrait() { | ||
| return new OrientationChangeAction(ActivityInfo.SCREEN_ORIENTATION_PORTRAIT); | ||
| } | ||
|
|
There was a problem hiding this comment.
While we are at it, can we include ActivityInfo.SCREEN_ORIENTATION_REVERSE_PORTRAIT and ActivityInfo.SCREEN_ORIENTATION_REVERSE_LANDSCAPE as well?
| onView(isRoot()).perform(orientationPortrait()); | ||
| onView(isRoot()).perform(orientationLandscape()); | ||
| onView(isRoot()).perform(orientationPortrait()); | ||
| onView(isRoot()).perform(orientationLandscape()); |
There was a problem hiding this comment.
One or two wait loops with different delays would be nice.
tobrun
force-pushed
the
tvn-orientation-test
branch
from
faa34d6
to
3ac8954
Compare
|
@LukasPaczos review comments have been addressed:
|
tobrun
force-pushed
the
tvn-orientation-test
branch
from
3ac8954
to
a406792
Compare
LukasPaczos
approved these changes
Jan 2, 2018
23 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a integration test that validates possible regressions related to orientation changes. Haven't been able to reproduce the crashes for which this test was created though I feel this would be a great addition to our test suite.
cc @LukasPaczos