Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Fix code generation #10856

Merged
merged 1 commit into from
Jan 9, 2018
Merged

Fix code generation #10856

merged 1 commit into from
Jan 9, 2018

Conversation

tobrun
Copy link
Member

@tobrun tobrun commented Jan 8, 2018

Closes #10846.

This PR fixes up the generated code by:

@tobrun tobrun added the Android Mapbox Maps SDK for Android label Jan 8, 2018
@tobrun tobrun added this to the android-v5.3.1 milestone Jan 8, 2018
@tobrun tobrun self-assigned this Jan 8, 2018
@LukasPaczos
Copy link
Member

@tobrun can we add lambdas to layer.junit.ejs template, to keep them in the resulting code?

@tobrun
Copy link
Member Author

tobrun commented Jan 9, 2018

I'm a bit on the fence about that. Mainly because of the time it would take vs the benefit. Getting this is in would result in a lot of trial/error while the only benefit would be readability. I don't feel the same rules of readability apply to generated code as it does with normal code.

Above is very opinionated so happy to hear your thoughts on it, am I missing something here?

If possible I would prefer the gameplan of ticketing out the lamba optimization and picking it up when we work on the template files themselves.

@LukasPaczos
Copy link
Member

If possible I would prefer the gameplan of ticketing out the lamba optimization and picking it up when we work on the template files themselves.

It's mainly internal tests, so let's ticket them out and come back later.

@tobrun
Copy link
Member Author

tobrun commented Jan 9, 2018

Ticket to update the template files in #10868

@tobrun tobrun merged commit 068d2f2 into master Jan 9, 2018
@tobrun tobrun deleted the tvn-fix-generated-code branch January 9, 2018 16:04
@tobrun tobrun mentioned this pull request Jan 10, 2018
23 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

#10810 updated a generated file without changing the source
2 participants