This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Add Hebrew localization #10967
Merged
Add Hebrew localization #10967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1ec5
added
iOS
tobrun
approved these changes
Jan 19, 2018
fabian-guerra
approved these changes
Jan 19, 2018
As long as the ornaments are laid out using leading and trailing constraints, we should be good to go, but it’s worth double-checking in the simulator given the recent iPhone X–related layout fixes. Note that there’s already an Arabic localization. |
23 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new Hebrew localization of the Android, iOS, and macOS map SDKs from Transifex. The localization isn’t quite 100% complete, but it has passed the 80% threshold for inclusion in this project.
I followed these instructions to add the localization, then added a blurb to each of the changelogs, since it’s a significant enhancement. I kept these changes separate from #10966 because they aren’t quite as straightforward as updating existing translations.
/cc @fabian-guerra @tobrun @akitchen