Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Add Hebrew localization #10967

Merged
merged 1 commit into from
Jan 19, 2018
Merged

Add Hebrew localization #10967

merged 1 commit into from
Jan 19, 2018

Conversation

1ec5
Copy link
Contributor

@1ec5 1ec5 commented Jan 19, 2018

Added a new Hebrew localization of the Android, iOS, and macOS map SDKs from Transifex. The localization isn’t quite 100% complete, but it has passed the 80% threshold for inclusion in this project.

I followed these instructions to add the localization, then added a blurb to each of the changelogs, since it’s a significant enhancement. I kept these changes separate from #10966 because they aren’t quite as straightforward as updating existing translations.

/cc @fabian-guerra @tobrun @akitchen

@1ec5 1ec5 added iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS Android Mapbox Maps SDK for Android localization Human language support and internationalization labels Jan 19, 2018
@1ec5 1ec5 self-assigned this Jan 19, 2018
Copy link
Contributor

@fabian-guerra fabian-guerra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

Just one question for Right-to-Left Languages are we changing the ornaments? or any other UI element?

@1ec5
Copy link
Contributor Author

1ec5 commented Jan 19, 2018

Just one question for Right-to-Left Languages are we changing the ornaments? or any other UI element?

As long as the ornaments are laid out using leading and trailing constraints, we should be good to go, but it’s worth double-checking in the simulator given the recent iPhone X–related layout fixes. Note that there’s already an Arabic localization.

@1ec5 1ec5 merged commit 40a0b2d into master Jan 19, 2018
@1ec5 1ec5 deleted the 1ec5-tx-he branch January 19, 2018 23:57
@tobrun tobrun mentioned this pull request Jan 26, 2018
23 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android iOS Mapbox Maps SDK for iOS localization Human language support and internationalization macOS Mapbox Maps SDK for macOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants