This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Make NSExpression+MGLAdditions.h public #11072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabian-guerra
approved these changes
Jan 29, 2018
There was a problem hiding this comment.
I overlooked that when I made my review. I am adding a specific check for project files to my PR review checklist (#10726 (review))
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#10726 made NSExpression+MGLAdditions.h public in the macOS project but not the iOS project. It also included the file in the iOS SDK’s umbrella header, so I’m concerned there may be some breakage in v4.0.0-beta.1 due to the umbrella header including a nonexistent file.
#5942 would head off problems like this by making all the targets available for selection when adding the file to an Xcode project.
/cc @friedbunny @fabian-guerra