Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Deprecate Mapbox locationengine #11185

Merged
merged 1 commit into from
Feb 13, 2018
Merged

Conversation

tobrun
Copy link
Member

@tobrun tobrun commented Feb 13, 2018

With #9771 we deprecated MyLocationView and other location related APIs. We seem to have forgotten to deprecate the LocationSource found in Mapbox.java

@tobrun tobrun added the Android Mapbox Maps SDK for Android label Feb 13, 2018
@tobrun tobrun added this to the android-v6.0.0 milestone Feb 13, 2018
@tobrun tobrun self-assigned this Feb 13, 2018
Copy link
Member

@LukasPaczos LukasPaczos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. I'm just missing a note about LocationLayerPlugin. Would be great if we can add that.

@@ -140,7 +140,7 @@ public static synchronized Boolean isConnected() {
*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a @deprecated comment pointing to LocationLayerPlugin as in

* @deprecated use location layer plugin from
* https://github.com/mapbox/mapbox-plugins-android/tree/master/plugins/locationlayer instead.
*/

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for flagging, fixed with 1d6655c

@tobrun tobrun force-pushed the tvn-deprecate-locationengine branch from 2788c39 to 1d6655c Compare February 13, 2018 12:23
@tobrun tobrun merged commit 7742992 into release-boba Feb 13, 2018
@tobrun tobrun deleted the tvn-deprecate-locationengine branch February 13, 2018 12:42
@tobrun tobrun mentioned this pull request Feb 13, 2018
23 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants