This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Revert to ImageView #11187
Merged
Revert to ImageView #11187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts using ImageView instead of AppCompatImageView. While it's best practice to use AppCompatImageViews for custom views (to enable automatic tinting). It also requires adding the design/appcompat library to the end user application. Often for customers in cn, this was perceived as an issue. To me the customer requests outways the functionality of automatic tinting (eg. attribution icon). In #10268 we addressed his by moving to ImageView instead.