Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Cherry-pick master changes into release-boba (mid-February edition) #11249

Merged
merged 8 commits into from
Feb 20, 2018
Merged

Cherry-pick master changes into release-boba (mid-February edition) #11249

merged 8 commits into from
Feb 20, 2018

Conversation

friedbunny
Copy link
Contributor

Cherry-picks some recent changes from master to release-boba:

/cc @asheemmamoowala @fabian-guerra

friedbunny and others added 8 commits February 19, 2018 14:52
@friedbunny
[ios] Fix safeAreaInsets availability warning in MGLMapViewLayoutTests
d72b54c 
Fixes: 'safeAreaInsets' is only available on iOS 11.0 or newer [-Wunguarded-availability-new]
@friedbunny
[ios] Fix type conversion warnings in MGLFeatureTests
aa63235 
Fixes: object of type 'MGLPointAnnotation/MGLPolyline *' is not compatible with array element type 'MGLShape<MGLFeature> *' [-Wobjc-literal-conversion]
@friedbunny
[ios] Fix iOS 8's broken pluralization in MGLCoordinateFormatterTests
58ac64e
@friedbunny
[ios] Bump testMGLMapSnapshotter timeout to 5s
41e4230 
Timing based tests are inherently flakey and prone to failure on slow CI:

> Test case 'MGLDocumentationExampleTests.testMGLMapSnapshotter()' failed on 'iPhone X' (3.375 seconds)
> Test case 'MGLDocumentationExampleTests.testMGLMapSnapshotter()' failed on 'iPhone 8' (3.413 seconds)
> Test case 'MGLDocumentationExampleTests.testMGLMapSnapshotter()' failed on 'iPhone 7' (2.944 seconds)
@friedbunny
[ios] Disable -[MGLExpressionTests testConditionalExpressionObject] o…
6130fb2 
…n iOS 8

Temporarily disable this test until iOS 8 compatibility is added.
@friedbunny
[ios] Fix loop when first asking for location permission (#11229)
e119be7
@friedbunny
[ios] Bump podspecs for 3.7.5
35e2c8b
@friedbunny
[core] Support a range of zooms in TileRange. Accounts for TilePyrami…
b9df1d9 
…d requesting parent tiles of ideal zoom tiles.
@friedbunny friedbunny added the iOS Mapbox Maps SDK for iOS label Feb 19, 2018
@friedbunny friedbunny self-assigned this Feb 19, 2018
@friedbunny friedbunny added this to the ios-v4.0.0 milestone Feb 19, 2018
@friedbunny
Copy link
Contributor Author

@ChrisLoer should we bring #11156 into release-boba, too?

@friedbunny friedbunny added the Core The cross-platform C++ core, aka mbgl label Feb 19, 2018
fabian-guerra
fabian-guerra approved these changes Feb 19, 2018
View reviewed changes
Copy link
Contributor

@fabian-guerra fabian-guerra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@fabian-guerra fabian-guerra added the beta blocker Blocks the next beta release label Feb 20, 2018
@ChrisLoer
Copy link
Contributor

ChrisLoer commented Feb 20, 2018 •
edited
Loading

@ChrisLoer should we bring #11156 into release-boba, too?

I don't think #11156 (expression serialization) should be very high-risk/destabilizing, so I'd be inclined to pull it in. But I also don't know how much it will unblock on its own vs. what we hope to get once iOS and Android have built wrappers around it? /cc @lilykaiser

asheemmamoowala
asheemmamoowala approved these changes Feb 20, 2018
View reviewed changes
Copy link
Contributor

@asheemmamoowala asheemmamoowala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CHANGELOG may need an entry for the TileJSON.bounds fix.

@friedbunny
Copy link
Contributor Author

friedbunny commented Feb 20, 2018 •
edited
Loading

Thanks, @asheemmamoowala — since these changes are also being included in future agua patch releases (#11248), we’ll want to do the changelogging there.

@friedbunny friedbunny merged commit 054d4d5 into release-boba Feb 20, 2018
@friedbunny friedbunny deleted the fb-post-ios-3.7.5-cherry-picks branch February 20, 2018 19:23
@friedbunny
Copy link
Contributor Author

@ChrisLoer we didn’t end up cherry-picking #11156 in this PR, just so you’re aware. 🙇

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@asheemmamoowala asheemmamoowala asheemmamoowala approved these changes

@fabian-guerra fabian-guerra fabian-guerra approved these changes

Assignees

@friedbunny friedbunny

Labels
beta blocker Blocks the next beta release Core The cross-platform C++ core, aka mbgl iOS Mapbox Maps SDK for iOS
Projects
None yet
Milestone
ios-v4.0.0-boba
Development

Successfully merging this pull request may close these issues.
4 participants
@friedbunny @ChrisLoer @fabian-guerra @asheemmamoowala