This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[android] jni clean up - missing a couple DeleteLocalRef #11253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tobrun please look at the changes. I am not 100% sure about them - it was easier to do then discuss. |
tobrun
reviewed
Feb 20, 2018
| return *conversion::convert<mbgl::Color, int>(env, polygon.Get(env, field)); | ||
| auto jColor = polygon.Get(env, field); | ||
| mbgl::Color color = *conversion::convert<mbgl::Color, int>(env, jColor); | ||
| jni::DeleteLocalRef(env, jColor); |
There was a problem hiding this comment.
jColor is of the type jint and these are just aliases for normal native value types, so there are no special lifetime or cleanup considerations.
| @@ -34,6 +34,7 @@ mbgl::CameraOptions CameraPosition::getCameraOptions(jni::JNIEnv& env, jni::Obje | |||
| static auto zoom = CameraPosition::javaClass.GetField<jni::jdouble>(env, "zoom"); | |||
|
|
|||
| auto center = LatLng::getLatLng(env, position.Get(env, target)); | |||
| jni::DeleteLocalRef(env, target); | |||
| auto name = jni::Make<std::string>(env, image.Get(env, nameField)); | ||
| auto jName = image.Get(env, nameField); | ||
| auto name = jni::Make<std::string>(env, jName); | ||
| jni::DeleteLocalRef(env, jName); |
There was a problem hiding this comment.
great find as well, do we need to delete the pixels local ref?
There was a problem hiding this comment.
@tobrun Turns out that
jni::GetArrayRegion(env, *pixels, 0, size, reinterpret_cast<jbyte*>(premultipliedImage.data.get())); does the release as per https://developer.android.com/training/articles/perf-jni.html
osana
force-pushed
the
osana-DelLocalRefs-more
branch
3 times, most recently
from
529b126 to
2f3fa19
Compare
tobrun
approved these changes
Feb 21, 2018
osana
force-pushed
the
osana-DelLocalRefs-more
branch
from
2f3fa19 to
a11692f
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.