This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[ios] Improved heading indicator arrow visibility #11337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabian-guerra
approved these changes
Feb 27, 2018
Yeah, this is true — the larger arrow does encroach on the solid white dot. If you zoom to the far corners of the arrow, you’ll also notice that the white stroke overlaps the outside of the dot by a pixel or two. These issues annoy me and detract slightly from the design, but I think that they’re acceptable as a quick fix. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10028. Made the heading indicator arrow 25% larger — this is a simple fix and is as large as the current implementation can go without obvious visual artifacts.
/cc @fabian-guerra @julianrex