This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Expose more gestures settings #11407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11331.
This PR includes:
The last one will enable users to set their own thresholds for in-progress gestures without it being overwritten by the default implementation.
I didn't see much use in exposing a builder for the gestures manager. Most of the interesting tricks are available through the library itself when the gesture is in progress rather than by setting an option. The best approach to take advantage of the library is using listeners for gesture state (ex.
MapboxMap.OnMoveListener#onMoveBegin) and manipulating the manager that can be obtained viaMapboxMap#getGesturesManager.Most typical use-cases should be included in #11406
This PR also fixes issues with passing a custom
AndroidGesturesManager, which should cover most of the advanced use-cases.