This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Calculating camera's LatLng for bounds without map padding #11410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11340.
When calculating camera's
LatLngfor bounds we were taking into account both map padding and additional bounds padding. Afterward, when moving the camera with any of#easeTo,#jumpTo,#flyTowe were applying map's padding once again resulting in the incorrect camera position.The solution is to calculate initial
LatLngof the new camera position with only additional padding, the one passed with bounds./cc @asheemmamoowala