-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Conversation
6d8c7ac
to
172c2b0
Compare
50fcf59
to
63f211a
Compare
63f211a
to
04cc3ee
Compare
public Expression getFilter() { | ||
Expression expression = null; | ||
Object object = nativeGetFilter(); | ||
if (object != null && object instanceof JsonArray) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there any other object types we expect here? Should we deal with those cases?
@@ -68,6 +68,8 @@ class Layer : private mbgl::util::noncopyable { | |||
|
|||
void setFilter(jni::JNIEnv&, jni::Array<jni::Object<>>); | |||
|
|||
jni::Object<jni::ObjectTag> getFilter(jni::JNIEnv&); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we type this more specific than Object
?
@ivovandongen thank you for the review, I addressed your comments in 145e1e0. (FWIW flagging that most of the code in this PR will be refactored out with #11419 and #11420) |
I see that Filter.none has been removed with no explicit replacement (as well as Filter.notHas). Are there any plans on making those explicitly available, or will we have to go with something more verbose such as Expression.not(Expression.any) and Expression.not(Expression.has)? |
the latter |
WIP, this PR provides Android binding integration for #11251:
setFilter(Expression filter)
MapboxMap#queryRenderedFeatures
Source#querySourceFeatures
on source typesLayer#setFilter
on layer types (code-gen)getFilter