Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Add missing jni::DeleteLocalRef #11608

Merged
merged 1 commit into from
Apr 9, 2018
Merged

Add missing jni::DeleteLocalRef #11608

merged 1 commit into from
Apr 9, 2018

Conversation

tobrun
Copy link
Member

@tobrun tobrun commented Apr 5, 2018

WIP, going over the project to spot missing DeleteLocalRefs.

@tobrun tobrun added the Android Mapbox Maps SDK for Android label Apr 5, 2018
@tobrun tobrun added this to the android-v6.0.0 milestone Apr 5, 2018
@tobrun tobrun self-assigned this Apr 5, 2018
@jfirebaugh
Copy link
Contributor

This uses jni::PushLocalFrame, so it shouldn't need explicit jni::DeleteLocalRef.

@tobrun
Copy link
Member Author

tobrun commented Apr 6, 2018

Thank you for flagging @jfirebaugh, wasn't aware that jni::PushLocalFrame made that possible. Have reverted the changes on the lines in https://github.com/mapbox/mapbox-gl-native/blob/master/platform/android/src/http_file_source.cpp#L88 and will be adding possible other missing delete local refs.

@tobrun tobrun requested a review from ivovandongen April 6, 2018 09:45
@tobrun tobrun merged commit c1dabbd into release-boba Apr 9, 2018
@tobrun tobrun deleted the tvn-delete-local-refs branch April 9, 2018 18:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants