Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Update layer immediately when changing its max/min zoom level (CP #11399) #11687

Merged
merged 1 commit into from
Apr 16, 2018

Conversation

LukasPaczos
Copy link
Member

CP #11399 to the release branch.
This setup includes node bindings for render tests that will start working when #11671 lands.

* [android][core] update layer immediately when changing it's max/min zoom

* [core] node bindings for layer zoom range

(cherry picked from commit 22b4ef1)
@LukasPaczos LukasPaczos added the Android Mapbox Maps SDK for Android label Apr 16, 2018
@LukasPaczos LukasPaczos added this to the android-v6.0.0 milestone Apr 16, 2018
@LukasPaczos LukasPaczos requested a review from tobrun April 16, 2018 10:23
@LukasPaczos LukasPaczos merged commit ddb9a28 into release-android-v6.0.0 Apr 16, 2018
@LukasPaczos LukasPaczos deleted the lp-cp-11399 branch April 16, 2018 16:27
@mb12
Copy link

mb12 commented Apr 16, 2018

@LukasPaczos Is there any reason why mutableImpl is not virtualized? It would allow setters for properties that are common to all layers to be implemented once in Layer::Impl.

@jfirebaugh
Copy link
Contributor

The return type would have to be Mutable<Layer::Impl>, and then the majority of uses of mutableImpl() would have to cast that to the derived impl. It would be more verbose than what we have now, which is generated code anyway.

@tobrun tobrun mentioned this pull request Apr 17, 2018
23 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants