Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Mark -presentCalloutFromRect:inView:constrainedToView:animated: unavailable #11738

Merged
merged 3 commits into from
Apr 19, 2018

Conversation

julianrex
Copy link
Contributor

No description provided.

…available (constrainedToRect variant supersedes)
@julianrex
Copy link
Contributor Author

/cc @jmkiley

@friedbunny friedbunny added the SEMVER-MAJOR Requires a major release according to Semantic Versioning rules label Apr 19, 2018
@@ -52,6 +52,8 @@ The 4.0._x_ series of releases will be the last to support iOS 8. The minimum iO
* The `MGLMapView.selectedAnnotations` property (backed by `-[MGLMapView setSelectedAnnotations:]`) now selects annotations that are off-screen. ([#9790](https://github.com/mapbox/mapbox-gl-native/issues/9790))
* The `animated` parameter to `-[MGLMapView selectAnnotation:animated:]` now controls whether the annotation and its callout are brought on-screen. If `animated` is `NO` then the annotation is selected if offscreen, but the map is not panned. Currently only point annotations are supported. Setting the `MGLMapView.selectedAnnotations` property now animates. ([#3249](https://github.com/mapbox/mapbox-gl-native/issues/3249))
* Fixed a crash when rapidly adding and removing annotations. ([#11551](https://github.com/mapbox/mapbox-gl-native/issues/11551), [#11575](https://github.com/mapbox/mapbox-gl-native/issues/11575))
* Marked protocol method `-[MGLCalloutView presentCalloutFromRect:inView:constrainedToView:animated:]` as unavailble. Please use `-[MGLCalloutView presentCalloutFromRect:inView:constrainedToRect:animated:]` instead (enabling moving off-screen annotations on-screen).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about the following blurb:

  • Added support for enabling moving off-screen annotations. (#11738)
  • Marked protocol method -[MGLCalloutView presentCalloutFromRect:inView:constrainedToView:animated:] as unavailble. Use -[MGLCalloutView presentCalloutFromRect:inView:constrainedToRect:animated:] instead. (#11738)

Copy link
Contributor Author

@julianrex julianrex Apr 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is really about removing potential confusion; adding support for moving off-screen annotations came in an earlier release No it wasn't 😄. Let me tweak.

Copy link
Contributor

@friedbunny friedbunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, ‘cept for the changelog notes. When you merge, please be sure to prefix the commit with [ios].

Update: whoop, looks like you already got the changelog stuff while I was doddling with my review.

@@ -52,6 +52,8 @@ The 4.0._x_ series of releases will be the last to support iOS 8. The minimum iO
* The `MGLMapView.selectedAnnotations` property (backed by `-[MGLMapView setSelectedAnnotations:]`) now selects annotations that are off-screen. ([#9790](https://github.com/mapbox/mapbox-gl-native/issues/9790))
* The `animated` parameter to `-[MGLMapView selectAnnotation:animated:]` now controls whether the annotation and its callout are brought on-screen. If `animated` is `NO` then the annotation is selected if offscreen, but the map is not panned. Currently only point annotations are supported. Setting the `MGLMapView.selectedAnnotations` property now animates. ([#3249](https://github.com/mapbox/mapbox-gl-native/issues/3249))
* Fixed a crash when rapidly adding and removing annotations. ([#11551](https://github.com/mapbox/mapbox-gl-native/issues/11551), [#11575](https://github.com/mapbox/mapbox-gl-native/issues/11575))
* Marked protocol method `-[MGLCalloutView presentCalloutFromRect:inView:constrainedToView:animated:]` as unavailble. Please use `-[MGLCalloutView presentCalloutFromRect:inView:constrainedToRect:animated:]` instead (enabling moving off-screen annotations on-screen).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

“unavailble” → unavailable

@@ -52,6 +52,8 @@ The 4.0._x_ series of releases will be the last to support iOS 8. The minimum iO
* The `MGLMapView.selectedAnnotations` property (backed by `-[MGLMapView setSelectedAnnotations:]`) now selects annotations that are off-screen. ([#9790](https://github.com/mapbox/mapbox-gl-native/issues/9790))
* The `animated` parameter to `-[MGLMapView selectAnnotation:animated:]` now controls whether the annotation and its callout are brought on-screen. If `animated` is `NO` then the annotation is selected if offscreen, but the map is not panned. Currently only point annotations are supported. Setting the `MGLMapView.selectedAnnotations` property now animates. ([#3249](https://github.com/mapbox/mapbox-gl-native/issues/3249))
* Fixed a crash when rapidly adding and removing annotations. ([#11551](https://github.com/mapbox/mapbox-gl-native/issues/11551), [#11575](https://github.com/mapbox/mapbox-gl-native/issues/11575))
* Marked protocol method `-[MGLCalloutView presentCalloutFromRect:inView:constrainedToView:animated:]` as unavailble. Please use `-[MGLCalloutView presentCalloutFromRect:inView:constrainedToRect:animated:]` instead (enabling moving off-screen annotations on-screen).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link to this PR at the end of the line.

@julianrex julianrex merged commit 2e22593 into release-boba Apr 19, 2018
@julianrex julianrex deleted the jrex-mark-constrainedToView-unavailable branch April 19, 2018 19:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
iOS Mapbox Maps SDK for iOS SEMVER-MAJOR Requires a major release according to Semantic Versioning rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants