Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Convert null to empty string, not “null” #11904

Merged
merged 1 commit into from
May 14, 2018

Conversation

1ec5
Copy link
Contributor

@1ec5 1ec5 commented May 14, 2018

["to-string", null] now evaluates to the empty string instead of the string "null".

This is a port of mapbox/mapbox-gl-js#6534 that fixes #11719. It depends on a cherry-pick of mapbox/mapbox-gl-js@d5c5ef5 atop mapbox/mapbox-gl-js@a4eed2f.

/cc @anandthakker @friedbunny

@1ec5 1ec5 added GL JS parity For feature parity with Mapbox GL JS Core The cross-platform C++ core, aka mbgl runtime styling labels May 14, 2018
@1ec5 1ec5 added this to the ios-v4.0.1 milestone May 14, 2018
@1ec5 1ec5 self-assigned this May 14, 2018
@1ec5 1ec5 requested a review from anandthakker May 14, 2018 19:21
@1ec5 1ec5 force-pushed the 1ec5-to-string-null-11719 branch from 8e146e7 to 148d1e4 Compare May 14, 2018 19:38
@1ec5
Copy link
Contributor Author

1ec5 commented May 14, 2018

The “nitpick” build is expected to fail on this branch and release-boba once we merge this PR, since we’re pinning to a branch of mapbox-gl-js other than master.

Copy link
Contributor

@anandthakker anandthakker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Note: this should be cherry-picked to master

@1ec5
Copy link
Contributor Author

1ec5 commented May 14, 2018

Note: this should be cherry-picked to master

Yes, we’ll be merging release-boba back to master following the ios-v4.0.1 and macos-v0.7.1 releases.

@1ec5 1ec5 merged commit 4b1530f into release-boba May 14, 2018
@1ec5 1ec5 deleted the 1ec5-to-string-null-11719 branch May 14, 2018 20:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Core The cross-platform C++ core, aka mbgl GL JS parity For feature parity with Mapbox GL JS runtime styling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants