This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Convert null to empty string, not “null” #11904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1ec5
added
GL JS parity
1ec5
force-pushed
the
1ec5-to-string-null-11719
branch
from
8e146e7
to
148d1e4
Compare
|
The “nitpick” build is expected to fail on this branch and release-boba once we merge this PR, since we’re pinning to a branch of mapbox-gl-js other than master. |
anandthakker
approved these changes
May 14, 2018
Yes, we’ll be merging release-boba back to master following the ios-v4.0.1 and macos-v0.7.1 releases. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
["to-string", null]now evaluates to the empty string instead of the string"null".This is a port of mapbox/mapbox-gl-js#6534 that fixes #11719. It depends on a cherry-pick of mapbox/mapbox-gl-js@d5c5ef5 atop mapbox/mapbox-gl-js@a4eed2f.
/cc @anandthakker @friedbunny