Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

[ios, macos] Fix computed shapes CPU usage. #11962

Closed
wants to merge 1 commit into from
Closed

[ios, macos] Fix computed shapes CPU usage. #11962

wants to merge 1 commit into from

Conversation

fabian-guerra
Copy link
Contributor

Fixes #11957

@fabian-guerra fabian-guerra added bug iOS Mapbox Maps SDK for iOS performance Speed, stability, CPU usage, memory usage, or power usage macOS Mapbox Maps SDK for macOS labels May 21, 2018
@fabian-guerra fabian-guerra self-assigned this May 21, 2018
asheemmamoowala
asheemmamoowala suggested changes May 21, 2018
View reviewed changes
Copy link
Contributor

@asheemmamoowala asheemmamoowala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fabian-guerra Were you able to determine what was causing the actual high CPU usage? Your fix will prevent the tile from reaching a loaded state and result in repeated requests for each tile with 0 features.

@fabian-guerra
Copy link
Contributor Author

@asheemmamoowala if the delegate MGLComputedShapeSourceDataSource returns an empty array of features then the CPU usage is kept around 97%

@fabian-guerra
Copy link
Contributor Author

Fixed in #11985

@fabian-guerra fabian-guerra deleted the fabian-computed-shape-11957 branch May 25, 2018 15:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@asheemmamoowala asheemmamoowala asheemmamoowala requested changes

Assignees

@fabian-guerra fabian-guerra

Labels
bug iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS performance Speed, stability, CPU usage, memory usage, or power usage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fabian-guerra @asheemmamoowala